! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
tabwin: New tweak to only show on the primary monitor
Status:
RESOLVED: MOVED
Severity:
enhancement

Comments

Description Dridi 2019-09-08 10:57:57 CEST
Created attachment 9012 
common: Add a xfwm_monitor_is_primary function

This adds a new boolean entry in the tweaks dialog that defaults to false to maintain existing behavior without user intervention. The new setting is called cycle_primary_monitor and currently lacks translations (although I could help with the French translation once the exact wording is decided).

The rationale behind this new tweak is that when I'm presenting with my laptop a mix of slides and demos in a terminal for example, I want the alt+tab window to only show up on my primary screen. Especially when the other screen or projector is recorded.

The attached patches achieve that, and I have tested it to the best of my abilities in a dual screen setup in a Fedora 30 VM, compiled for both gtk >= 3.22 or not (although runtime was always gtk 3.24).
Comment 1 Dridi 2019-09-08 10:58:51 CEST
Created attachment 9013 
tabwin: New tweak to only show on the primary monitor
Comment 2 Miro Hrončok 2019-09-10 12:28:14 CEST
primary screen or the screen with focus? Because the latter would make more sense to me.
Comment 3 Dridi 2019-09-10 12:51:59 CEST
If it's the screen with focus, then the tabwin shows up where I alternate between a slide deck and a terminal during a typical presentation, so both windows show up in the tabwin along with the window containing my speaker notes that lives on my primary screen.

Picking the screen with focus would completely defeat the purpose of this patch.
Comment 4 Dridi 2019-10-31 17:28:39 CET
Created attachment 9171 
common: Add a xfwm_monitor_is_primary function
Comment 5 Dridi 2019-10-31 17:29:20 CET
Created attachment 9172 
tabwin: Comply with the primary monitor setting
Comment 6 Dridi 2019-10-31 17:43:11 CET
We had a chance to discuss this with Olivier Fourdan and the main problem with the initial submission is the addition of a new tweak. So instead, we agreed that setting a primary display would be enough to limit the Alt+Tab window to that screen, and otherwise keep showing it on all screens.

During our discussion I mentioned that the reason I initially went for a new tweak was because GTK+3 would always provide a primary monitor, falling back to the first monitor. This is already the case on my system, but I don't know why, maybe my GTK configuration. It however doesn't matter because GTK+3 eventually enforced this behavior in a later release.

So the direction we agreed on was to go one layer down and ask X11 RandR about the primary monitor.

The first patch is still the same as before, but since I'm submitting them as a series I updated both. The second patch no longer introduces a new tweak, but I didn't change the bug title to reflect that.
Comment 7 Git Bot editbugs 2020-05-29 12:30:17 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/350.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15942

Reported by:
Dridi
Reported on: 2019-09-08
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
1 user

Version

Version:
GIT Master

Attachments

Additional information