! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Ctrl+Mousewheel does not enlarge/shrink entries (for detailed list view)
Status:
RESOLVED: FIXED

Comments

Description DarkTrick 2019-09-06 10:14:21 CEST
Reproduce:
=======

1) Open Thunar
2) Menu -> View -> View as detailed list
3) Try to enlarge listed items with Ctrl + mousewheel

expected:
4) Items get enlarged / shrink (as in the other views)

actual:
4) Scroll-action is triggered


Further information:
=============
- This problem did not appear under xubuntu 18.10 LTS, Thunar
- This problem does not exist for the other view options
- [Ctrl]+[+] does work for item size change
Comment 1 DarkTrick 2019-09-06 10:56:03 CEST
Correction:
- This problem did not appear under xubuntu 18.04 LTS, Thunar
Comment 2 alexxcons editbugs 2019-09-07 11:56:00 CEST
I can confirm the bug. To checked which commit made the difference. ( Possibly related to exo )
Comment 3 Theo Linkspfeifer editbugs 2019-09-07 14:29:51 CEST
The problem seems to be that event->direction in thunar_standard_view_scroll_event() returns GDK_SCROLL_SMOOTH.

With GDK_CORE_DEVICE_EVENTS=1 set this issue is not present.
Comment 4 alexxcons editbugs 2019-09-07 22:00:35 CEST
(In reply to Theo Linkspfeifer from comment #3)
> The problem seems to be that event->direction in
> thunar_standard_view_scroll_event() returns GDK_SCROLL_SMOOTH.
> 
> With GDK_CORE_DEVICE_EVENTS=1 set this issue is not present.

But only for detailed view.  This bug was not present in thunar 1.6.x ... seems like it first showed in 1.7.0. Probably related to gtk2 --> gtk3 transition.
Comment 5 Theo Linkspfeifer editbugs 2019-09-25 13:17:53 CEST
Yes, this is only about the detailed list view as mentioned in the bug description. I do not know how to properly fix this though.
Comment 6 Theo Linkspfeifer editbugs 2019-09-25 13:22:40 CEST
Created attachment 9054 
hack

I used this change for a quick test.
Comment 8 alexxcons editbugs 2019-12-21 13:54:42 CET
Created attachment 9322 
patrch

Uh, thanks for the patch, I somehow missed it. Works for me for detailed view, but  breaks feature for the other views.

Wonder why "event->direction" is "GDK_SCROLL_SMOOTH" for detailed view ... according to the doc, I need to check the deltas in this case, like done in your linked commit.

Attached a patch.
I cannot test the "misc-horizontal-wheel-navigates" part, since I dont have a horizontal "wheel" (trackball?) ... possibly you have such a device ?
Comment 9 Theo Linkspfeifer editbugs 2019-12-22 15:00:48 CET
Patch works. I emulated horizontal scrolling by remapping the scroll direction via xbindkeys:

# ~/.xbindkeysrc
"xdotool click 6"
  b:4

"xdotool click 7"
  b:5
Comment 10 Git Bot editbugs 2019-12-22 18:18:34 CET
Alexander Schwinn referenced this bugreport in commit a1108af1d4c03773534038d552aa56c8cddbe662

Ctrl+Mousewheel does not enlarge/shrink entries (for detailed list view) (Bug #15936)

https://git.xfce.org/xfce/thunar/commit?id=a1108af1d4c03773534038d552aa56c8cddbe662
Comment 11 Git Bot editbugs 2019-12-22 18:19:37 CET
Alexander Schwinn referenced this bugreport in commit ec58e00ea9fe50a4c24e634744decbea016f81dd

Ctrl+Mousewheel does not enlarge/shrink entries (for detailed list view) (Bug #15936)

https://git.xfce.org/xfce/thunar/commit?id=ec58e00ea9fe50a4c24e634744decbea016f81dd
Comment 12 alexxcons editbugs 2019-12-22 18:20:48 CET
Good idea ! Thanks for testing !

Pushed it to master and 4.14 branch.
Comment 13 alexxcons editbugs 2019-12-30 21:29:11 CET
*** Bug 16319 has been marked as a duplicate of this bug. ***

Bug #15936

Reported by:
DarkTrick
Reported on: 2019-09-06
Last modified on: 2019-12-30
Duplicates (1):
  • 16319 STRG+Mousewheel dont resize icons/previews

People

Assignee:
alexxcons
CC List:
3 users

Version

Attachments

hack (581 bytes, patch)
2019-09-25 13:22 CEST , Theo Linkspfeifer
no flags
patrch (3.18 KB, patch)
2019-12-21 13:54 CET , alexxcons
no flags

Additional information