! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Search fails for queries containing accented letters
Status:
RESOLVED: FIXED
Product:
Xfce4-appfinder
Component:
General

Comments

Description Sebastian Jakubiak 2019-08-28 16:06:17 CEST
Created attachment 8964 
Patch with the fix

When the text in the search box contains a character with a diacritic, the application list is empty even if there should be some matching entries.

For example, xfce4-accessibility-settings.desktop is named 'Ułatwienia dostępu' in Polish. If I type 'dost' in the search box, the results include that app. If I type 'dostę', the list of results becomes empty.
Comment 1 Git Bot editbugs 2019-09-01 18:58:03 CEST
Andre Miranda referenced this bugreport in commit f55f2f9a21c2ab44512cb8a515c10230775ad301

Use casefolded string when searching for apps not commands (Bug #15893)

https://git.xfce.org/xfce/xfce4-appfinder/commit?id=f55f2f9a21c2ab44512cb8a515c10230775ad301
Comment 2 Andre Miranda editbugs 2019-09-01 18:59:52 CEST
The proposed patch would revert this commit:
https://git.xfce.org/xfce/xfce4-appfinder/commit/?id=034dcf4

And possibly interfere with the fuzzy logic:
https://git.xfce.org/xfce/xfce4-appfinder/commit/?id=486a9ae

I hope the fix above is a good compromise between fuzzy searching commands and search apps with utf-8 characters regardless of its case but keep the fuzziness.

Bug #15893

Reported by:
Sebastian Jakubiak
Reported on: 2019-08-28
Last modified on: 2019-09-01

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.14.0

Attachments

Patch with the fix (1.19 KB, patch)
2019-08-28 16:06 CEST , Sebastian Jakubiak
no flags

Additional information