! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Raise NameError and TypeError
Status:
RESOLVED: FIXED
Product:
Xfce4-screensaver
Component:
General

Comments

Description Olivier Duchateau 2019-08-15 10:37:48 CEST
Created attachment 8889 
Avoid NameError and TypeError

In particular case, when src/xfce4-screensaver-configure runs without parameter (without saver). We get these errors:

>>Traceback (most recent call last):
>>  File "src/xfce4-screensaver-configure", line 791, in <module>
>>    show_fatal(primary, _("Screensaver required.") % saver)
>>NameError: name 'primary' is not defined
>>
>>Traceback (most recent call last):
>>  File "src/xfce4-screensaver-configure", line 793, in <module>
>>    show_fatal(primary, _("Screensaver required.") % saver)
>>TypeError: not all arguments converted during string formatting

Patch fixes this issue.
Comment 1 Git Bot editbugs 2020-01-15 12:20:30 CET
Olivier Duchateau referenced this bugreport in commit a5da8a4b5abb19dc88616dbe60974162041f2888

Raise NameError and TypeError (bug #15830)

https://git.xfce.org/apps/xfce4-screensaver/commit?id=a5da8a4b5abb19dc88616dbe60974162041f2888
Comment 2 Sean Davis editbugs 2020-01-15 12:20:59 CET
Thanks! Applied above.

Bug #15830

Reported by:
Olivier Duchateau
Reported on: 2019-08-15
Last modified on: 2020-01-15

People

Assignee:
Sean Davis
CC List:
0 users

Version

Attachments

Avoid NameError and TypeError (1.09 KB, patch)
2019-08-15 10:37 CEST , Olivier Duchateau
no flags

Additional information