Hello, Would it be possible to implement an option for the side panel to use symbolic icons for user folders? Most file managers seem to adopt such approach and it would make the transition between dark theme and light theme smoother as GTK would automatically paint them. If not by default, it would be a nice option to have.
Created attachment 8757 proof-of-concept.diff The attached diff is a proof of concept, it's missing the option to make this feature an opt-in and forces thunar icon factory to always load symbolic icons thus files on the main view are also affected (not intentionally). I have tested some icon themes and the results are mixed: - Adwaita: looks good (bold icons, same as high contrast) - Gnome: bad contrast, light gray icons on white background - Elementary Xfce: looks very good - Faenza: same as Gnome - Numix: almost same as Gnome, but with a red trash icon - Moka: bad contrast, light gray icons on white background I might be missing something, but symbolic icons didn't look good on most themes.
Created attachment 8758 elementary-xfce
Created attachment 8759 gnome
(In reply to Andre Miranda from comment #1) > Created attachment 8757 > proof-of-concept.diff > > The attached diff is a proof of concept, it's missing the option to make > this feature an opt-in and forces thunar icon factory to always load > symbolic icons thus files on the main view are also affected (not > intentionally). > Hi Andre, Thank you for this! I haven't tested it yet but I will soon > I have tested some icon themes and the results are mixed: > - Adwaita: looks good (bold icons, same as high contrast) > - Gnome: bad contrast, light gray icons on white background > - Elementary Xfce: looks very good > - Faenza: same as Gnome > - Numix: almost same as Gnome, but with a red trash icon > - Moka: bad contrast, light gray icons on white background > > I might be missing something, but symbolic icons didn't look good on most > themes. Just a note about the icon themes: The availability of symbolic icons in a theme depends on the theme itself. Adwaita and Papirus (mising in your test, and will test myself) are probably the most complete ones and I've been helping Simon with elementary-xfce adding missing ones. Gnome icons is now obsolete and deprecated in favor of Adwaita. Faenza hasn't seen an update in years. Numix and Moka being actively maintained should be able to have such issue addressed.
Hi, Just wanted to add support for an option to use symbolic icons in the sidebar. This is in relation to Linux Mint's XFCE edition where the non-symbolic home icon prevents the devs using their first choice of side bar background colour for the default Mint theme. https://github.com/linuxmint/mint19.3-beta/issues/41
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/252. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev