! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Change Camelcase to Title Case
Status:
RESOLVED: FIXED

Comments

Description scootergrisen 2019-06-08 13:40:49 CEST
When renaming multiple files we have:
lowercase
UPPERCASE
Camelcase
First character uppercase

But is Camelcase even Camelcase here?
Reading wikipedia it seems Camelcase does not use spaces.
So maybe it should be "Title Case" which would also indicate what will happen to the words with the big T and C just like the other strings shows what will happen.
Comment 1 Git Bot editbugs 2019-06-09 13:55:46 CEST
Andre Miranda referenced this bugreport in commit bec303d43a62e0511e9a11a3e6bac9cc80221c0f

Rename Camelcase to Title Case (Bug #15579)

https://git.xfce.org/xfce/thunar/commit?id=bec303d43a62e0511e9a11a3e6bac9cc80221c0f
Comment 2 Andre Miranda editbugs 2019-06-09 13:56:33 CEST
Makes sense.

P.S. I also pushed to master, but with the wrong bug number...
Comment 3 scootergrisen 2019-06-09 17:47:55 CEST
Maybe change this to:
THUNAR_SBR_CASE_RENAMER_MODE_CAMEL

And thunar/plugins/thunar-sbr/thunar-sbr-case-renamer.c have:
                    gboolean     camelcase)
       if (camelcase
     case THUNAR_SBR_CASE_RENAMER_MODE_CAMEL:

Seems like g_unichar_isspace is the function that converts the text if camelcase is true i dont know what it does.
Maybe its able to convert to both camel case and title case.
Comment 4 Git Bot editbugs 2019-06-16 23:04:53 CEST
Andre Miranda referenced this bugreport in commit 5f1c6df022992718d979e07d24ab06d0988f108a

Rename (Bug #15579)

https://git.xfce.org/xfce/thunar/commit?id=5f1c6df022992718d979e07d24ab06d0988f108a
Comment 5 Git Bot editbugs 2019-06-16 23:05:32 CEST
Andre Miranda referenced this bugreport in commit 6e84219f0879d7f5024702ef7fdcbdefc34d60bb

Rename (Bug #15579)

https://git.xfce.org/xfce/thunar/commit?id=6e84219f0879d7f5024702ef7fdcbdefc34d60bb
Comment 6 Andre Miranda editbugs 2019-06-16 23:06:07 CEST
(In reply to scootergrisen from comment #3)
> Maybe change this to:
> THUNAR_SBR_CASE_RENAMER_MODE_CAMEL
> 
> And thunar/plugins/thunar-sbr/thunar-sbr-case-renamer.c have:
>                     gboolean     camelcase)
>        if (camelcase
>      case THUNAR_SBR_CASE_RENAMER_MODE_CAMEL:
> 
Done.

> Seems like g_unichar_isspace is the function that converts the text if
> camelcase is true i dont know what it does.
> Maybe its able to convert to both camel case and title case.
It just checks if a character is whitespace or not.

Bug #15579

Reported by:
scootergrisen
Reported on: 2019-06-08
Last modified on: 2019-06-16

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Additional information