! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Terminating a program crashes session editor
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Theo Linkspfeifer editbugs 2019-05-28 14:28:13 CEST
The crash happens when one tries to terminate a running program with restart style "immediately".


(xfce4-session-settings:10954): GLib-CRITICAL **: 14:27:10.057: g_variant_builder_end: assertion 'ensure_valid_builder (builder)' failed

(xfce4-session-settings:10954): GLib-CRITICAL **: 14:27:10.057: g_variant_get_type: assertion 'value != NULL' failed

(xfce4-session-settings:10954): GLib-CRITICAL **: 14:27:10.057: g_variant_type_is_array: assertion 'g_variant_type_check (type)' failed

(xfce4-session-settings:10954): GLib-CRITICAL **: 14:27:10.057: g_variant_get_type_string: assertion 'value != NULL' failed

(xfce4-session-settings:10954): GLib-ERROR **: 14:27:10.057: g_variant_new: expected array GVariantBuilder but the built value has type '(null)'
Comment 1 Theo Linkspfeifer editbugs 2019-05-28 14:30:06 CEST
Created attachment 8591 
trace.log
Comment 2 Theo Linkspfeifer editbugs 2019-05-29 14:31:07 CEST
Created attachment 8599 
diff

After adapting the code changes from commit 38a881 to the part which triggers the crash I can now terminate the selected program.

https://git.xfce.org/xfce/xfce4-session/commit/settings/session-editor.c?id=38a8819834264020c5de6c628c8d402dc11e58dd
Comment 3 Git Bot editbugs 2019-06-17 00:01:07 CEST
Theo Linkspfeifer referenced this bugreport in commit 5f7d120c9646beeb0bcfad2b306f8f3ce81752ad

settings: Fix crash when terminating programs (Bug #15489)

https://git.xfce.org/xfce/xfce4-session/commit?id=5f7d120c9646beeb0bcfad2b306f8f3ce81752ad
Comment 4 Simon Steinbeiss editbugs 2019-06-17 00:01:31 CEST
Thanks for reporting and fixing the bug!
Comment 5 Theo Linkspfeifer editbugs 2019-07-11 10:22:04 CEST
*** Bug 15701 has been marked as a duplicate of this bug. ***

Bug #15489

Reported by:
Theo Linkspfeifer
Reported on: 2019-05-28
Last modified on: 2019-07-11
Duplicates (1):
  • 15701 "Session and Startup" crashes when quitting xfdesktop

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Version:
4.13.2

Attachments

trace.log (1.61 KB, application/octet-stream)
2019-05-28 14:30 CEST , Theo Linkspfeifer
no flags
diff (1.97 KB, patch)
2019-05-29 14:31 CEST , Theo Linkspfeifer
no flags

Additional information