! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Crash when we right click on any unmounted volume in left tree panel
Status:
RESOLVED: FIXED

Comments

Description hapical 2019-05-22 20:02:09 CEST
Created attachment 8571 
journalctl dumped core

Right click on any unmounted volume in left tree panel make thunar to crash.


Arch linux 64 bits updated.
xfce4 and thunar updated.
Comment 1 alexxcons editbugs 2019-05-23 23:39:47 CEST
Thanks for reporting !

I cannot reproduce this bug. Does it always happen for you, or just rarely ?

Does the crash happen for all kind of volumes ? How did you mount / unmount it ?

Could you please try to generate a backtrace with debug symbols ? ( Without symbols it is almost useless ) 
Here some distro-specific how to: https://docs.xfce.org/contribute/bugs/start
Comment 2 hapical 2019-05-24 01:16:39 CEST
Created attachment 8576 
Backtrace  Trace.log
Comment 3 hapical 2019-05-24 01:18:21 CEST
Created attachment 8577 
Backtrace

Yes, the crash happens with all UNMOUNTED partitions, volumes (connected hard disk, ssd), MTP device(android) and usb pendrives, when I click with right mouse button on them. Only unmounted ones that shows the tree view
Comment 4 Git Bot editbugs 2019-05-24 03:44:36 CEST
Andre Miranda referenced this bugreport in commit 479655f5ccaf9189d9599c941c563fe5ae32578e

Fix crash on unmounted volume in tree pane right click (Bug #15452)

https://git.xfce.org/xfce/thunar/commit?id=479655f5ccaf9189d9599c941c563fe5ae32578e
Comment 5 Git Bot editbugs 2019-05-24 03:45:24 CEST
Andre Miranda referenced this bugreport in commit ba3502eaaf398ef5fac12dcc9d23fe47959c4eba

Fix crash on unmounted volume in tree pane right click (Bug #15452)

https://git.xfce.org/xfce/thunar/commit?id=ba3502eaaf398ef5fac12dcc9d23fe47959c4eba
Comment 6 Andre Miranda editbugs 2019-05-24 03:47:17 CEST
I guess this regression was introduce by this commit:
https://git.xfce.org/xfce/thunar/commit/?id=cb12bc1

We should not rely on _thunar_return_val_if_fail or g_return_val_if_fail for NULL check, those macros are only meant for debugging.
Comment 7 alexxcons editbugs 2019-06-02 22:38:21 CEST
*** Bug 15508 has been marked as a duplicate of this bug. ***

Bug #15452

Reported by:
hapical
Reported on: 2019-05-22
Last modified on: 2019-06-02
Duplicates (1):
  • 15508 Thunar 1.8.6-2 is crashing, when ejecting USB stick properly. Thunar-volman is verson 0.9.2-1

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Attachments

journalctl dumped core (4.27 KB, application/octet-stream)
2019-05-22 20:02 CEST , hapical
no flags
Backtrace Trace.log (2.98 KB, text/x-log)
2019-05-24 01:16 CEST , hapical
no flags
Backtrace (2.98 KB, text/x-log)
2019-05-24 01:18 CEST , hapical
no flags

Additional information