Created attachment 8439 eject icon hidden under scroll bar See screenshot attached. What works for me as a solution somehow is to wait a second until the scrollbar is resized. Just moving the cursor to the center of the sidebar, at least far enough so the scrollbar loses the focus. Nevertheless that's no real proper solution. Maybe the icon could force some more padding to the scrollbar initially?
This only happens with overlay scrollbars. This gtk3 snippet will create the space required to make the eject buttons reachable: /* make eject buttons reachable */ .thunar .sidebar .view { padding-right: 10px; }
Thanks! But where should this snippet go to fix the problem permanently? Pushing it to every Gtk theme can't be the way, right?
Created attachment 8450 alternative approach The attached patch is an alternative approach which does not use CSS. I also noticed that it takes at least 12px so the scrollbar won't overlap when the cursor is over it. Another problem is that the first time you plug an external drive, the eject button is very close to the sidebar's border, but if you eject and plug it back the back will be a bit far. This behavior is already present but makes the extra padding even worse.
Thanks, that looks much better now! Could we get this patch merged?
I'm not merging any because they solve this problem creating another: the button now is too far from the border which means less room for the device label. Also AFAIK there is no (non-hacky) way to the sidebar width. So I hoping for third approach.
*** Bug 15593 has been marked as a duplicate of this bug. ***
*** Bug 16078 has been marked as a duplicate of this bug. ***
Created attachment 9160 diff Try this. The spinner does not seem to require any extra padding. For me it only appeared when unmounting a device, and thus always to the left of the eject symbol.
Having an extra column for the eject symbol reduces the available width for all other labels though.
Related report: Bug 15708
Created attachment 9187 fix.diff (In reply to Theo Linkspfeifer from comment #9) > Having an extra column for the eject symbol reduces the available width for > all other labels though. Correct. And that's something I want to avoid. See the attached diff, I was able to get rid of the eject_column (idk, maybe the problem it was meant to workaround was fixed in gtk) and made the padding conditional to the scroll bar visibility.
Andre Miranda referenced this bugreport in commit 78c15641e0aa6f780c6766056a848428ab1d8e60 Extra padding for Eject button when scrollbar is visible (Bug #15312) https://git.xfce.org/xfce/thunar/commit?id=78c15641e0aa6f780c6766056a848428ab1d8e60
I've pushed to master, please let me know if it works well for you before closing this bug and cherry picking into xfce-4.14 branch.
Works well.
Andre Miranda referenced this bugreport in commit 31cf70d534afa7a9ea5ad75a024fa880ea4a4667 Extra padding for Eject button when scrollbar is visible (Bug #15312) https://git.xfce.org/xfce/thunar/commit?id=31cf70d534afa7a9ea5ad75a024fa880ea4a4667