! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Remove frame from logout dialog
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Kirill Afonin 2019-04-13 13:33:10 CEST
This frame should not be.
I have disabled all xfce effects. To avoid screen breaks.
Comment 1 Kirill Afonin 2019-04-13 14:54:11 CEST
Created attachment 8400 
Frame at completion.
Comment 2 Andre Miranda editbugs 2019-04-13 18:46:45 CEST
Sorry, I don't understand what's the problem, do you mean you don't want that frame around logout dialog? If so, I think that was removed since xfce4-session was ported to gtk3.
Comment 3 Kirill Afonin 2019-04-13 22:56:49 CEST
I do not need the blue color of the window frames, this does not fit with the theme and background, I have not seen this before, because was blue background color.
Comment 4 Andre Miranda editbugs 2019-04-14 02:22:45 CEST
Moving to the correct product, as I said this seems to have been removed in 4.13.
Comment 5 Kirill Afonin 2019-04-14 09:00:03 CEST
I have version 4.12.
And when can I get an update to the GTK3 version?
Comment 6 Andre Miranda editbugs 2019-04-14 16:54:48 CEST
It depends on your distribution. On Arch you may use AUR packages, for Debian there is an experimental package, but I couldn't find a PPA for Ubuntu.
The other options are to build from source or wait for the 4.14 release.
I'm leaving this bug open because I'm not completely sure that frame was removed.
Comment 7 Simon Steinbeiss editbugs 2019-04-23 23:05:16 CEST
These lines tell me the 6px border around the "window" hasn't been removed:
https://git.xfce.org/xfce/xfce4-session/tree/xfce4-session/xfsm-logout-dialog.c#n171

To be honest I'd consider redesigning that dialog a little instead of simply dropping the border.
Comment 8 Simon Steinbeiss editbugs 2019-04-23 23:40:45 CEST
I dug into the code a bit more and this line is the culprit:
https://git.xfce.org/xfce/xfce4-session/tree/xfce4-session/xfsm-logout-dialog.c#n835

I'll remove it and add some css style class on the dialog instead so themes can actually do something with it (e.g. add borders or rounded corners or whatnot).
Comment 9 Git Bot editbugs 2019-04-23 23:57:52 CEST
Simon Steinbeiss referenced this bugreport in commit e50b62fced8bcb12871543bfad3e6ae49638092f

Remove blue border from logout dialog (Bug #15284)

https://git.xfce.org/xfce/xfce4-session/commit?id=e50b62fced8bcb12871543bfad3e6ae49638092f

Bug #15284

Reported by:
Kirill Afonin
Reported on: 2019-04-13
Last modified on: 2019-04-23

People

Assignee:
Simon Steinbeiss
CC List:
2 users

Version

Version:
Unspecified

Attachments

Frame at completion. (645.59 KB, image/jpeg)
2019-04-13 14:54 CEST , Kirill Afonin
no flags

Additional information