Created attachment 8282 Fix compiler warnings With GCC 8 (no messages with Clang) I get these warnings: > xfconf-channel.c: In function 'xfconf_channel_get_g_property': > xfconf-channel.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=] > g_value_set_boolean(value, channel->is_singleton); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >xfconf-channel.c:331:9: note: here > default: > ^~~~ >xfconf-daemon.c: In function 'xfconf_daemon_backend_property_changed': >xfconf-daemon.c:135:20: warning: assignment to 'XfconfDaemon *' {aka 'struct _XfconfDaemon *'} from incompatible pointer type 'GObject *' {aka 'struct _GObject *'} [-Wincompatible-pointer-types] > pdata->xfconfd = g_object_ref(G_OBJECT(user_data)); > ^ >xfconf-daemon.c:136:20: warning: assignment to 'XfconfBackend *' {aka 'struct _XfconfBackend *'} from incompatible pointer type 'GObject *' {aka 'struct _GObject *'} [-Wincompatible-pointer-types] > pdata->backend = g_object_ref(G_OBJECT(backend)); > ^ Patch fixes this issue.
Olivier Duchateau referenced this bugreport in commit 0cb3bfa9adb383117251e0799beafcc7e89fcb10 Fix warnings reported by GCC 8 (Bug #15112) https://git.xfce.org/xfce/xfconf/commit?id=0cb3bfa9adb383117251e0799beafcc7e89fcb10
LGTM, merged, thanks!