"Applications Menu" panel items allow to define a custom icon - either by selecting it from a list of icons, or by specifying a corresponding image file (eg. a .png file). In 4.13 the second option (specifying an image file) does not work any more: - the first steps in the selection process do work correctly (opening the properties properties popup window -> opening the Icon-selection popup window -> setting the top-row combo to "Image Files" -> browsing to an image file -> selecting that image file - the icon defined in that image file is correctly displayed in the properties popup window - closing the image-file selection popup by hitting OK but: - after closing the image-file selection window, the selected icon does not appear in the panel item - a void marker icon is displayed instead - this is a mere problem of the display of the icon in the panel item, its functionality is correct see also: https://bugs.mageia.org/show_bug.cgi?id=23993 And, please note that Mageia realises that 4.13 is a development release. Nevertheles, Xfce in the upcoming Mageia-7 will based that release (given the relatively long release cycle of Mageia this is in the interest of its users).
This commit caused the regression: https://git.xfce.org/xfce/xfce4-panel/commit?id=c04e40bcbf319b294f2e34f374fdb350571d6f72 I think the removed code chunk, more specifically xfce_panel_pixbuf_from_source_at_size also handles file paths instead of just icon names.
Thanks for this very rapid reply. Mageia-7 is planned to go into version freeze on Jan 2. Is a corrected release of xfce4-panel planned before that date, or should Mageia consider introducing a local patch?
Hi Jürgen, sorry for the late reply, but obviously nothing happened in time. I think this shouldn't be too hard to fix, but if you come up with a patch for Mageia please feel free to post it here, maybe we can simply merge it in instead of re-writing it.
I took another look at the code and the fix is most likely to simply revert that commit. What Andrzej wanted can be achieved differently too, although I'm not sure why he wanted to drop support for non-square icons.
Simon Steinbeiss referenced this bugreport in commit dc1f684d600884583d93cfbdae6b78a6b2b9ee9f Revert "Applications menu icon sizing fixes" (Bug #14976) https://git.xfce.org/xfce/xfce4-panel/commit?id=dc1f684d600884583d93cfbdae6b78a6b2b9ee9f
Reverted the commit, therefore restoring the image file feature.
*** Bug 15020 has been marked as a duplicate of this bug. ***