! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Enable close-after-select functionality
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Catfish
Component:
General

Comments

Description pmkielstra 2018-11-18 21:12:47 CET
Created attachment 8115 
Patch to enable close-after-select functionality

I like to use Catfish as a way to find and open files.  It's easier
to search for "xyz.txt" than it is to actually remember where I put
xyz.txt.  The downside is that Catfish stays open while I'm editing
xyz.txt, leading to me having several Catfish windows in the back-
ground that I then have to close manually.  This patch adds a new
option to close immediately after opening a file.

It is also hosted on GitHub at Michaelkielstra/Catfish.
Comment 1 Ari 2018-12-08 18:07:08 CET
I came searching to open a feature request for the exact same functionality!

I have been using catfish for a few months with pretty much the same usecase as OP, and the only improvement I can think of is the one added by this feature request/merge request.

Looking forward to seeing the code contributed by @pmkielstra merged sometime soon

Thanks!
Comment 2 Sean Davis editbugs 2019-07-22 20:06:54 CEST
I'm open to including this feature, but the patch does not currently apply to git master. Can you rebase it on master and resubmit? Thanks!
Comment 3 pmkielstra 2019-07-24 18:04:48 CEST
Created attachment 8809 
The same patch, but rebased to master.  (Also, by default, close-after-select is False, so users don't suddenly get new behaviour after updating.)
Comment 4 pmkielstra 2019-07-24 18:05:08 CEST
(In reply to Sean Davis from comment #2)
> I'm open to including this feature, but the patch does not currently apply
> to git master. Can you rebase it on master and resubmit? Thanks!

Done!  Thanks.
Comment 5 Git Bot editbugs 2019-08-13 11:36:32 CEST
Michael Kielstra referenced this bugreport in commit e0ae1828ae434ea76a4c1b2919b8a5812da14723

Added close-after-select functionality and rebased to current master (Bug #14888)

https://git.xfce.org/apps/catfish/commit?id=e0ae1828ae434ea76a4c1b2919b8a5812da14723
Comment 6 Sean Davis editbugs 2019-08-13 11:37:01 CEST
Your patch works like a charm! Applied above.

Bug #14888

Reported by:
pmkielstra
Reported on: 2018-11-18
Last modified on: 2019-08-13

People

Assignee:
Sean Davis
CC List:
1 user

Version

Attachments

Additional information