! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
version 0.1.1 depends on devel libxfce4ui
Status:
RESOLVED: FIXED
Product:
Xfce4-screensaver
Component:
General

Comments

Description Guido Falsi 2018-11-01 11:09:43 CET
Created attachment 8072 
Patch reverting to old gtk_widget_reparent

While testing porting xfce4-screensaver to freeBSD I noticed that while the configure script requires libxfce4-ui 4.12.1 the file src/xfce4-screensaver-preferences.c uses the xfce_widget_reparent() call, which is present only in version 4.13.0. This causes the linker to file if the stable version of the library is present.

Either the requirement should be bumped, but this would cause the program to be usable only with the xfce development release, or the call to xfce_widget_reparent() could be demoted to gtk_widget_reparent() for the time being.

I'm attaching a simple patch for the latter.
Comment 1 Git Bot editbugs 2018-11-01 23:39:15 CET
Sean Davis referenced this bugreport in commit 8c04927e33675e3e76d82b5c0788cb3df97d6584

Resolve hidden libxfce4ui 4.13 requirement (bug #14821)

https://git.xfce.org/apps/xfce4-screensaver/commit?id=8c04927e33675e3e76d82b5c0788cb3df97d6584
Comment 2 Git Bot editbugs 2018-11-01 23:40:17 CET
Sean Davis referenced this bugreport in commit 168afbab12eb293d0f832daf8cc262d453b7d443

Fix bad copy-paste job (bug #14821)

https://git.xfce.org/apps/xfce4-screensaver/commit?id=168afbab12eb293d0f832daf8cc262d453b7d443
Comment 3 Sean Davis editbugs 2018-11-01 23:40:48 CET
This should be resolved with the above 2 commits.

Bug #14821

Reported by:
Guido Falsi
Reported on: 2018-11-01
Last modified on: 2018-11-01

People

Assignee:
Sean Davis
CC List:
0 users

Version

Version:
unspecified

Attachments

Patch reverting to old gtk_widget_reparent (512 bytes, text/x-csrc)
2018-11-01 11:09 CET , Guido Falsi
no flags

Additional information