Created attachment 8041 screenshot xfce4-screensaver is crashed when i change image style and run `xfce4-screensaver-command -l` on default desktop Output: linxon@cirno-chan:~ $ xfconf-query -c xfce4-desktop -p /backdrop/screen0/monitor0/image-style 0 linxon@cirno-chan:~ $ xfce4-screensaver ** (xfce4-screensaver:9135): WARNING **: Failed to get session presence proxy: Could not get owner of name 'org.gnome.SessionManager': no such name ** ERROR:xfce-bg.c:939:draw_image_area: code should not be reached Аварийный останов
Sean Davis referenced this bugreport in commit 341d377055671b4de087e0748a39b9a9d1e22494 Fix color property pulling, support background filename with no placement (bug #14769) https://git.xfce.org/apps/xfce4-screensaver/commit?id=341d377055671b4de087e0748a39b9a9d1e22494
Fix applied in the above commit.
Maybe resolved, but in locked mode (login dialog) i see only black background It can't get a color property using my configuration for `xfdesktop-4.12.4` My config: <property name="workspace0" type="empty"> <property name="color-style" type="int" value="3"/> <property name="image-style" type="int" value="0"/> <property name="last-image" type="string" value="/home/linxon/2.jpg"/> <property name="color1" type="array"> <value type="uint" value="0"/> <value type="uint" value="5498"/> <value type="uint" value="13400"/> <value type="uint" value="65535"/> </property> <property name="backdrop-cycle-enable" type="bool" value="false"/> <property name="brightness" type="int" value="0"/> <property name="saturation" type="double" value="1.000000"/> <property name="color2" type="array"> <value type="uint" value="1996"/> <value type="uint" value="9725"/> <value type="uint" value="19752"/> <value type="uint" value="65535"/> </property> </property> Thank you!
@Yury, this is due to a change in how colors are processed between GTK 2 and GTK 3. I've added a commit below that should make your configuration work, if you want to test it out. https://git.xfce.org/apps/xfce4-screensaver/commit/?id=20ccbec35c9d537144712ce7a08410ff562ed6a4
@Yury, You'll actually need this commit as well. You should be able to test this by building git master. https://git.xfce.org/apps/xfce4-screensaver/commit/?id=9ac974f0ccd35e9ed29b62ef978184b2360c5232
it works! Thank you wery much! :) P.S. (Not critical!) If you try to remove old config `xfce4-desktop.xml` and relogin, the Xfdesktop generates a new configuration that looks like this: <?xml version="1.0" encoding="UTF-8"?> <channel name="xfce4-desktop" version="1.0"> <property name="backdrop" type="empty"> <property name="screen0" type="empty"> <property name="monitor0" type="empty"> <property name="workspace0" type="empty"> <property name="color-style" type="int" value="0"/> <property name="image-style" type="int" value="0"/> <property name="last-image" type="string" value="/usr/share/backgrounds/xfce/xfce-teal.jpg"/> </property> <property name="workspace1" type="empty"> <property name="color-style" type="int" value="0"/> <property name="image-style" type="int" value="5"/> <property name="last-image" type="string" value="/usr/share/backgrounds/xfce/xfce-teal.jpg"/> </property> </property> </property> </property> <property name="last" type="empty"> <property name="window-width" type="int" value="757"/> <property name="window-height" type="int" value="526"/> </property> </channel> Unfortunately, i can't find here `<property name="color1" type="array">...</property>` block of code. When you try to change image-style to '0' using this default configuration you see colored background (#152233) but in locked mode used black color. Maybe you need use defaults of https://git.xfce.org/xfce/xfdesktop/tree/src/xfce-backdrop.c#n768 instead of black? Thank you! :)
Thanks for the suggestion! Applied this change to master, and closing out this bug now.