! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Incorrect XI2 event mask setup
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfwm4
Component:
General

Comments

Description timo.teras 2018-09-12 08:21:22 CEST 
Created attachment 7976 
Fix

The mask_len field is setup incorrectly in xfwm_device_fill_xi2_event_mask(). sizeof is the pointer length, not the bitmask data area length.
Comment 1 timo.teras 2018-09-12 08:22:42 CEST 
May also fix bug #14648.
Comment 2 timo.teras 2018-09-12 08:27:01 CEST 
In practice, sizeof the pointer is 8 on 64-bit platforms. Where the mask length is 4 bytes. This caused several places to access 4 extra bytes beyond allocated memory with uninitialized values.
Comment 3 Landry Breuil editbugs 2018-09-12 08:48:07 CEST 
it also seems to fix bug #14580, with the patch i'm able to build xfwm4 4.13.1 with xi2 enabled on OpenBSD, and it starts fine.
Comment 4 Olivier Fourdan editbugs 2018-09-13 20:28:17 CEST 
*** Bug 14580 has been marked as a duplicate of this bug. ***
Comment 5 Olivier Fourdan editbugs 2018-09-13 20:28:35 CEST 
*** Bug 14648 has been marked as a duplicate of this bug. ***
Comment 6 Git Bot editbugs 2018-09-13 20:28:54 CEST 
Timo referenced this bugreport in commit 2080fa3c81b3810228ae5a8abbb494c78dd1d566

device: Fix wrong mask len

https://git.xfce.org/xfce/xfwm4/commit?id=2080fa3c81b3810228ae5a8abbb494c78dd1d566
Comment 7 Olivier Fourdan editbugs 2018-09-13 20:29:21 CEST 
Pushed, thanks!

Bug #14695

Reported by:
timo.teras
Reported on: 2018-09-12
Last modified on: 2018-09-13
Duplicates (2):
  • 14580 4.13.1 wont start, chokes on eventFilterAddWin()
  • 14648 XI2 event handling causes visible stutters or total lack of response

People

Assignee:
Olivier Fourdan
CC List:
3 users

Version

Version:
unspecified
Target Milestone:
Xfce 4.12

Attachments

Fix (457 bytes, patch)
2018-09-12 08:21 CEST , timo.teras 		no flags

Additional information