! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix xfwm4 launch in xinitrc when xfce4-session disabled
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description ToZ editbugs 2018-09-07 00:45:52 CEST
Created attachment 7960 
[PATCH] Fix xfwm4 launch in xinitrc

When not using xfce4-session, the /etc/xdg/xfce4/xinitrc script runs the commands in the bottom half of the script. Unfortunately, the script now hangs because of the "xfwm4 --daemon" command - the "--daemon" parameter has been deprecated and the command hangs the script.

Attached is a patch that changes the command to "xfwm4 &" to allow it to start and the script to continue.
Comment 1 Marcos Mello 2019-03-12 00:47:09 CET
Why would anyone run XFCE without xfce4-session? Just curious, as it appears to be an essential component.
Comment 2 Skunnyk editbugs 2019-05-06 14:13:15 CEST
Same question here: I can't get how you can trigger the "else" (no xfce4-session found: https://git.xfce.org/xfce/xfce4-session/tree/scripts/xinitrc.in.in#n106) part of the xinitrc, because the xinitrc file IS provided by xfce4-session. It seems to be only a legacy case, before the introduction of xfce4-session.

Initially, startxfce4/xinitrc were provided by a 3rd party package (xfce-utils), that's why you can have a pattern where you run xinitrc without xfce4-session, see https://git.xfce.org/archive/xfce-utils/commit/scripts/xinitrc?id=a150f6ea431db96b9d62d1311540445e93585038 / https://git.xfce.org/archive/xfce-utils/commit/scripts/xinitrc?id=a676916665d742cc25ed780e563c0d5aea99d0b0

However, since 4.8 or 4.10, it is merged in xfce4-session: https://git.xfce.org/xfce/xfce4-session/commit/?id=6d37293024adbbeb205246d1377b5420e6c6f485 

So I +1 the removal of the part which handle the "no xfce4-session" in xinitrc.
Comment 3 Marcos Mello 2019-05-06 20:53:31 CEST
I see no point maintaining this stuff in shell when we have proper C code.
Comment 4 ToZ editbugs 2019-05-06 21:02:40 CEST
The bug report was created as a result of this forum thread: https://forum.xfce.org/viewtopic.php?id=12425. Currently, it is possible to disable xfce4-session (although kludgy) and have a working environment.

There must have been a reason originally to create the option, but the question as to whether this should continue to be supported is a good one.
Comment 5 Git Bot editbugs 2019-05-08 19:06:41 CEST
Romain Bouvier referenced this bugreport in commit a7a413a6f3644d052a504a6a0e286f28053920b1

xinitrc: Remove fallback path when xfce4-session is not installed

https://git.xfce.org/xfce/xfce4-session/commit?id=a7a413a6f3644d052a504a6a0e286f28053920b1
Comment 6 Skunnyk editbugs 2019-05-13 13:39:09 CEST
*** Bug 14187 has been marked as a duplicate of this bug. ***

Bug #14681

Reported by:
ToZ
Reported on: 2018-09-07
Last modified on: 2019-05-13
Duplicates (1):
  • 14187 Exec in ~/.config/autostart/*.desktop doesn't support commands with arguments

People

Assignee:
Skunnyk
CC List:
6 users

Version

Version:
4.13.1

Attachments

Additional information