! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Rightclick won't work
Status:
RESOLVED: FIXED
Product:
Catfish
Component:
General

Comments

Description Sebastian Stroppel 2018-08-21 18:54:48 CEST
The problem affects some basic operation you want to do: Search for some files and move it to another place.

Normally you would search for the files with catfish. After that you would mark them in catfish and let them show in the file manager. Then you would move them.

The problem: Catfish does not allow any rightclick anymore on marked files. After installation of an older version the rightclick worked, but not the function to show the marked files in the file manager.
Comment 1 Sebastian Stroppel 2018-08-21 18:56:48 CEST
I am using a Lenovo 110S by the way.
Comment 2 Gregor Santner 2018-09-02 12:00:11 CEST
Affecting me too. Has happened on all of my devices, at both Arch Linux and Debian based distros.
Comment 3 Sar Oumane 2018-10-03 15:36:53 CEST
Catfish 1.4.4
If I launch alone catfish : no problem.
If I launch Catfish from within Thunar (with the very useful "Custom Action", I bind Control + F on "catfish --path=%f") : I can't rightclick on files found by Catfish.
Comment 4 SiOn 2018-12-05 23:31:54 CET
Confirmed.

Catfish 1.4.6 on Arch
Wether launching catfish alone or from Thunar (by a hot key such as Ctrl+F), there's no right click menu from search results.
Comment 5 frankzz 2019-01-18 14:38:14 CET
Created attachment 8251 
Fix context menu not opening after shift/ctrl key by connecting correct key-release-event (bug #14621, #14743, #14999)

The bug 14743 and the bug 14999 are different manifestations of this bug.

To sum it up: whenever the shift or the control key is pressed or released the context menu will not pop up anymore until catfish is closed and reopened. So even entering a capital letter in the search edit field or multi-selection in the result list is sufficient to reproduce the bug.

The problem appears to have been introduced in catfish 1.4.1
commit 2829d07 Fix click issues in treeview (LP: #1547807, #1523164)

The reason for the bug is that the key-release-event is connected to the key-press handler instead of the key-release handler. Catfish uses this to maintain a list of currently pressed modifier keys and does not allow any custom click actions if shift or control key is in this list. The bug prevents catfish from ever removing any recorded keys.

The FIX is simple. On an installed system just execute this line:

sudo sed -e 's/"key-release-event" handler="on_catfish_window_key_press_event"/"key-release-event" handler="on_catfish_window_key_release_event"/' -i /usr/share/catfish/ui/CatfishWindow.ui

This has been tested on xubuntu 18.04, the first LTS that includes a catfish version that exhibits this problem.

The proper git patch is attached.
Comment 6 frankzz 2019-01-18 14:59:22 CET
The bug 14538 also has the same root cause.
Comment 7 Git Bot editbugs 2019-01-20 04:11:23 CET
frankzz referenced this bugreport in commit 5fc25f6f97c04ab6e4676d145490229b5380189a

Fix context menu not opening after shift/ctrl key by connecting correct key-release-event (bug #14621, #14743, #14999)

https://git.xfce.org/apps/catfish/commit?id=5fc25f6f97c04ab6e4676d145490229b5380189a
Comment 8 Sean Davis editbugs 2019-01-20 04:12:15 CET
Thanks for the patch! Applied at the above commit.
Comment 9 Sean Davis editbugs 2019-01-20 04:13:21 CET
*** Bug 14743 has been marked as a duplicate of this bug. ***
Comment 10 Sean Davis editbugs 2019-01-20 04:13:45 CET
*** Bug 14999 has been marked as a duplicate of this bug. ***
Comment 11 Sean Davis editbugs 2019-01-20 04:14:17 CET
*** Bug 14538 has been marked as a duplicate of this bug. ***

Bug #14621

Reported by:
Sebastian Stroppel
Reported on: 2018-08-21
Last modified on: 2019-01-20
Duplicates (3):
  • 14538 unable to mass delete search results
  • 14743 Pop-up menu disappears
  • 14999 Multiple deleting and right click

People

Assignee:
Sean Davis
CC List:
7 users

Version

Attachments

Additional information