! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Messed up row-height with disabled "automatically expand columns as needed" i...
Status:
RESOLVED: FIXED

Comments

Description alexxcons editbugs 2018-07-22 23:30:01 CEST
When  "automatically expand columns as needed" is disabled,  zooming in(or out) multiple times and than press F5 will mess up the row height and the icon size of some rows.
Comment 1 Git Bot editbugs 2018-07-22 23:39:50 CEST
Alexander Schwinn referenced this bugreport in commit f7304357489b23090af11a27d626414cb5d9dd11

Fix of messed up row-height with disabled "automatically expand columns as needed" in detailed view. (Bug #14548)

https://git.xfce.org/xfce/thunar/commit?id=f7304357489b23090af11a27d626414cb5d9dd11
Comment 2 Git Bot editbugs 2018-07-22 23:42:38 CEST
Alexander Schwinn referenced this bugreport in commit 91eeeeb892ebb72f4f4574901ce73369e1440647

Fix of messed up row-height with disabled "automatically expand columns as needed" in detailed view. (Bug #14548)

https://git.xfce.org/xfce/thunar/commit?id=91eeeeb892ebb72f4f4574901ce73369e1440647
Comment 3 alexxcons editbugs 2018-07-23 11:13:33 CEST
it's not fully solved yet:
- sometimes, some items are not resized, but on f5 everything looks good
- gray background at the end of view, reproducible sometimes when going from large to small icons
Comment 4 alexxcons editbugs 2018-07-26 22:29:47 CEST
Created attachment 7847 
patch

This patch is more complete that the first attempt
Comment 5 alexxcons editbugs 2018-07-26 22:35:38 CEST
The following use-cases seem to be good for reproducing the bug:

Reproduce wrong/mixed row-height:
- Open the thunar folder and press "CTRL -" till minimum, than "CTRL +" till maximum. Than scroll down.

Reproduce gray background:
- Open /sbin and press  "CTRL +" till maximum, than "CTRL -" till mimimum. Than scroll down to the bottom.
- hover on the column head to "fix" the situation. Repeat step 1 to make it worse
Comment 6 alexxcons editbugs 2018-07-26 22:55:30 CEST
Created attachment 7848 
patch

fixed compile warning
Comment 7 Andre Miranda editbugs 2018-07-29 00:30:03 CEST
It's works well for me now, thanks!
Comment 8 Git Bot editbugs 2018-07-29 22:11:35 CEST
Alexander Schwinn referenced this bugreport in commit 9e068ccb788673d631d88ad89fd6ec81e9b7d915

Fix of messed up row-height with disabled "automatically expand columns as needed" in detailed view. (Part II) (Bug #14548)

https://git.xfce.org/xfce/thunar/commit?id=9e068ccb788673d631d88ad89fd6ec81e9b7d915
Comment 9 Git Bot editbugs 2018-07-29 22:15:26 CEST
Alexander Schwinn referenced this bugreport in commit aa026e0132faedf04536fff3abeb12717d23d0a1

Fix of messed up row-height with disabled "automatically expand columns as needed" in detailed view. (Part II) (Bug #14548)

https://git.xfce.org/xfce/thunar/commit?id=aa026e0132faedf04536fff3abeb12717d23d0a1
Comment 10 alexxcons editbugs 2018-07-29 22:16:57 CEST
Thanks alot for testing !   Hope it can stay closed this time ;-)
Comment 11 alexxcons editbugs 2018-07-30 22:09:50 CEST
Created attachment 7851 
Patch to make use of threads-add-idle

Use threads_add_idle to make sure that "gtk_tree_view_column_queue_resize" finished before "thunar_details_view_set_fixed_columns" and "thunar_standard_view_reload" are called.
Comment 12 alexxcons editbugs 2018-07-30 23:00:06 CEST
Created attachment 7852 
Patch to make use of threads-add-idle
Comment 13 Git Bot editbugs 2018-07-30 23:23:28 CEST
Alexander Schwinn referenced this bugreport in commit b946e6a4b8f33624b33bb14de4c2e0c4f8c3138b

Fix of messed up row-height with disabled "automatically expand columns as needed" in detailed view. (Part III) - use of "gdk_threads_add_idle" to make sure that queue_resize is finished before thunar_details_view_set_fixed_columns is called - revert of making "thunar_standard_view_reload" public, not required any more (Bug #14548)

https://git.xfce.org/xfce/thunar/commit?id=b946e6a4b8f33624b33bb14de4c2e0c4f8c3138b
Comment 14 Git Bot editbugs 2018-07-30 23:26:23 CEST
Alexander Schwinn referenced this bugreport in commit 069141d6abb3826cdf866618f9f1b8422a9ac728

Fix of messed up row-height with disabled "automatically expand columns as needed" in detailed view. (Part III) - use of "gdk_threads_add_idle" to make sure that queue_resize is finished before thunar_details_view_set_fixed_columns is called - revert of making "thunar_standard_view_reload" public, not required any more (Bug #14548)

https://git.xfce.org/xfce/thunar/commit?id=069141d6abb3826cdf866618f9f1b8422a9ac728

Bug #14548

Reported by:
alexxcons
Reported on: 2018-07-22
Last modified on: 2018-07-30

People

Assignee:
alexxcons
CC List:
3 users

Version

Attachments

patch (5.33 KB, patch)
2018-07-26 22:29 CEST , alexxcons
no flags
patch (5.35 KB, patch)
2018-07-26 22:55 CEST , alexxcons
no flags
Patch to make use of threads-add-idle (1.77 KB, patch)
2018-07-30 22:09 CEST , alexxcons
no flags
Patch to make use of threads-add-idle (1.55 KB, patch)
2018-07-30 23:00 CEST , alexxcons
no flags

Additional information