! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
translated strings in menu showing Menu|foo in some locales
Status:
RESOLVED: FIXED
Product:
Thunar-vcs-plugin
Component:
General

Comments

Description Landry Breuil editbugs 2018-06-22 11:13:12 CEST
Created attachment 7809 
screenshot

Initially i thought the Q_ macro in all the add_subaction didnt correctly split the 'Menu' context, even if the g_dpgettext doc seem to say | should be used as the separator - https://developer.gnome.org/glib/stable/glib-I18N.html#g-dpgettext - but in the end maybe the translations are wrong, and the 'context' should only be in msgid ?

Shows with fr_FR and es locales at least, but not en_US (as there's no po file) and not de (as strings are properly translated).
Should the translators have a hint that the 'Menu|' part in msgid has to be stripped from msgstr ? I dont really understand why are we bothering with different strings here for name and text ?

A quick grep on the po files shows a bunch of affected translations:

~/src/xfce4/thunar-vcs-plugin/ $grep -l 'msgstr "Menu' po/*.po 
po/en_AU.po
po/es.po
po/fr.po
po/hu.po
po/ms.po
po/nl.po
po/pl.po
po/pt_BR.po
po/sv.po
po/tr.po

Contrary to what i thought before this doesnt seem to be a regression with gtk3.
Comment 1 Andre Miranda editbugs 2018-06-24 20:38:16 CEST
I have just pushed a change to use C_ instead of Q_:
https://git.xfce.org/thunar-plugins/thunar-vcs-plugin/commit/?id=9c91cda35a2d621d8ca9307eba0ca59b97ba8fa0

Hopefully that will avoid further confusions.
Thanks for looking into this.
Comment 2 Andre Miranda editbugs 2018-08-24 05:42:13 CEST
I think it's safe to close this bug by now.

Bug #14472

Reported by:
Landry Breuil
Reported on: 2018-06-22
Last modified on: 2018-08-24

People

Assignee:
Andre Miranda
CC List:
0 users

Version

Version:
unspecified

Attachments

screenshot (146.10 KB, image/png)
2018-06-22 11:13 CEST , Landry Breuil
no flags

Additional information