Created attachment 7777 [PATCH] Use pkg-config to find FreeType This is needed in order to detect FreeType 2.9.1 which defaults to not shipping /usr/bin/freetype-config. (There is an --enable-freetype-config build option for FreeType, but it's not used by Arch Linux.)
Your attach patch will work only with FreeType >= 2.9.1, it removes he freetype-config based configure code. Not everybody ships with the latest version of FreeType. If you can provide a better patch, I'll be happy to merge it. Otherwise, I will try to address this when there will be enough fixes to worth a release.
Sorry about the incorrect patch. Do you think passing the existing freetype-config detection code as the last argument to PKG_CHECK_MODULES() would be an acceptable solution here? If yes, I can prepare and test a patch that does that.
Yes of course, the important point is that it works with freetype-config and with freetype >= 2.9.1 pkg-config. Thanks!
I looked more into it and I believe my original patch might actually be fine. The freetype2.pc file has existed since 2003 so the freetype-config fallback is unneeded. [1] What seems to have changed in 2.9.1 is that the CMake build now also installs freetype2.pc. Thing is, the CMake build doesn't install freetype-config. Based on the above, I cannot think of a case where freetype-config would be present but freetype2.pc would not. Please correct me if I'm missing something. [1] http://git.savannah.gnu.org/cgit/freetype/freetype2.git/log/builds/unix/freetype2.in
I agree with that. pkgconfig is the thing to use, especially since it is used all over the place in XFCE. Usage of *-config has to be removed.
The patch has been pushed to master, will be included in 0.2.2.