! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Accept network paths in ffmpeg thumbnailer plugin
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description Evangelos Foutras 2018-06-11 11:26:35 CEST
Created attachment 7776 
[PATCH] Accept network paths in ffmpeg thumbnailer plugin

In my testing, this change allows the ffmpeg thumbnailer plugin to generate thumbnails on samba shares.

Quoting my mailing list post:

    I am not completely confident that removing the call to g_file_is_native() is the correct
    approach here; if it's wrong, perhaps someone more knowledgeable could suggest an alternative.

https://mail.xfce.org/pipermail/xfce4-dev/2018-June/032128.html
Comment 1 Evangelos Foutras 2018-08-13 02:51:03 CEST
@Ali: Sorry I missed your reply on the mailing list. [1]

To answer your question, I'm generating the thumbnails by navigating to the network share in Thunar.

[1] https://mail.xfce.org/pipermail/xfce4-dev/2018-June/032134.html
Comment 2 Ali Abdallah editbugs 2018-09-02 08:44:24 CEST
The patch has been pushed to master, will be included in 0.2.2 release. Thanks

Bug #14445

Reported by:
Evangelos Foutras
Reported on: 2018-06-11
Last modified on: 2018-09-02

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Attachments

Additional information