! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Dont build from source
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description David 2018-05-07 13:33:21 CEST
Hi xfce4 folks,

when I build xfce4-session-4.13.0 from source, I get this error.
``
source/xfce4-session/xfsm-global.h:30:10: fatal error: dbus/dbus.h: No such file or directory
 #include <dbus/dbus.h>
``

I hope you can help me with this.

Best
David
Comment 1 Paul Menzel 2018-05-07 17:08:52 CEST
*** Bug 14387 has been marked as a duplicate of this bug. ***
Comment 2 Paul Menzel 2018-05-14 16:02:00 CEST
The problem is the pkg-config file of libxfce4ui-2.

On Debian Sid/unstable, where xfce4-session 4.13.0 builds the D-Bus include paths are present.

    $ pkg-config --cflags libxfce4ui-2
    -pthread -I/usr/include/xfce4/libxfce4ui-2 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include

In our distribution they are not.

    $ pkg-config --cflags libxfce4ui-2
    -pthread -I/usr/include/xfce4/libxfce4ui-2 -I/usr/include/gtk-3.0 -I/usr/include/xfce4 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/libpng15
Comment 3 Paul Menzel 2018-05-14 16:38:31 CEST
As Xfce4-session uses D-Bus now, it should explicitly list these dependencies and not depend on implicit inclusion.

In Debian Sid/unstable the D-Bus includes come for example from atk-bridge-2.0.

    $ pkg-config --cflags atk-bridge-2.0
    -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
Comment 4 Brandon Bergren 2018-08-25 20:15:06 CEST
I am seeing this on Gentoo ppc64 as well. It's not using the correct include path.

It looks to me like the d-bus direct depenencies were actually taken out in 91860af3a38080d45fef68ea623624ef25d7d9ec, but the #include <dbus/dbus.h> in xfce4-session/xfsm-global.h and the #include <dbus/dbus-glib.h> line in xfsm-error.c got left in accidentally. I tried commenting these two lines out and got a successful build.
Comment 5 Brandon Bergren 2018-08-25 20:25:34 CEST
Created attachment 7909 
fix build failure when dbus is not in the system include path

And here's a patch.
Comment 6 Git Bot editbugs 2018-08-26 16:29:54 CEST
Brandon Bergren referenced this bugreport in commit 3bddf152b902d8a1e0f674b792577b2cca635c4b

fix build failure when dbus is not in the system include path (Bug #14386)

https://git.xfce.org/xfce/xfce4-session/commit?id=3bddf152b902d8a1e0f674b792577b2cca635c4b
Comment 7 Eric Koegel editbugs 2018-08-26 16:30:24 CEST
Pushed to master, thanks!

Bug #14386

Reported by:
David
Reported on: 2018-05-07
Last modified on: 2018-08-26
Duplicates (1):
  • 14387 `xfsm-global.h:30:10: fatal error: dbus/dbus.h: No such file or directory`

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
4.13.0

Attachments

Additional information