! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfsettingsd --replace does not replace old daemon
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Xfsettingsd

Comments

Description Jason Zaman 2018-05-05 16:09:55 CEST
Created attachment 7711 
0001-xfsettingsd-dbus-connection-needs-setup-with-g_main-.patch

--replace doesnt work so the old daemons stay around. when i login i end up with like 30 xfsettingsd's sitting around for some weird reason.
the problem was the dbus events were not getting through.

attaching the patch to fix it. 

From: Jason Zaman <jason ATperfinion.com>
Date: Sat, 5 May 2018 15:52:54 +0800
Subject: [PATCH] xfsettingsd: dbus connection needs setup with g_main and
 listen for NameLost

Without calling dbus_connection_setup_with_g_main, no dbus events get
processed. causing xfsettingsd --replace to not work leaving many old
xfsettingsd around.

Also the signal NameLost gets sent instead of NameOwnerChanged so listen
for both now.

Signed-off-by: Jason Zaman <jason AT perfinion.com>
---
 xfsettingsd/main.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
Comment 1 Jason Zaman 2018-06-05 09:50:40 CEST
This is no longer needed, the problem was fixed when converting to gdbus in 
https://bugzilla.xfce.org/show_bug.cgi?id=14426
Comment 2 Sean Davis editbugs 2018-06-19 11:54:30 CEST
Fix applied to the xfce-4.12 branch.
https://git.xfce.org/xfce/xfce4-settings/commit/?h=xfce-4.12&id=89f26ff5c3ea4d7e0dbe2764c5c6eae48e0a30f5

Thanks!

Bug #14381

Reported by:
Jason Zaman
Reported on: 2018-05-05
Last modified on: 2018-06-19

People

Assignee:
Nick Schermer
CC List:
3 users

Version

Version:
unspecified

Attachments

Additional information