Created attachment 7664 Port to GDBus According to freedesktop.org DBus-GLib is obsolete and [new] applications should use GDBus. This patch changes dependency from dbus-glib to dbus.
After applying the patch to git master I had to add the changes to main.c manually. Also, it was necessary to make the following change, so that make would not complain: <-mousepad-dbus-infos.[ch]: mousepad-dbus-infos.xml Makefile ->mousepad-dbus-infos.h mousepad-dbus-infos.c: mousepad-dbus-infos.xml Makefile
Created attachment 8458 Port to GDBus Rebase on current master, fixed make targets.
Thanks. I can verify that it works as intended. Tested with these D-Bus method calls: gdbus call --session --dest=org.xfce.Mousepad --object-path /org/xfce/Mousepad --method org.xfce.Mousepad.Terminate gdbus call --session --dest=org.xfce.Mousepad --object-path /org/xfce/Mousepad --method org.xfce.Mousepad.LaunchFiles "/tmp" "['/tmp/foo.txt']"
Created attachment 8531 Port to GDBus Fix merge conflict with current master.
Created attachment 8537 updated patch - Updated to git master - Fixed whitespace warning The patch looks good, both dbus methods work as expected, I'm just concerned about the check on "dbus-1", I don't think it's necessary except for the conditional flag it creates. What I see in other Xfce components is this check: AC_CHECK_PROG([GDBUS_CODEGEN],[gdbus-codegen],[gdbus-codegen])
Created attachment 8647 mousepad-gdbus.patch Now configure checks for gdbus-codegen, but it is still possible to disable DBUS support. I also removed client code that used dbus-glib.
(In reply to Andre Miranda from comment #6) > Created attachment 8647 > mousepad-gdbus.patch > > Now configure checks for gdbus-codegen, but it is still possible to disable > DBUS support. > I also removed client code that used dbus-glib. I tested this patch and seems to work fine including when building an rpm package.
Arkadiy Illarionov referenced this bugreport in commit e9e4e30777a4bb24f9e6045942bdfb8937a1a571 Port to GDBus (Bug #14337) https://git.xfce.org/apps/mousepad/commit?id=e9e4e30777a4bb24f9e6045942bdfb8937a1a571