! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Single click mode does not always select items
Status:
RESOLVED: MOVED

Comments

Description Massimo Burcheri 2018-02-20 07:52:01 CET
Having enabled Preferences->Behavior->[x]Single click to activate items

How to reproduce:
1. Enable side pane tree view
2. Select a directory by click
3. Hover a file in the file view

Single click only works on the file view, not on the directory tree pane, which is ok. But after selecting a directory the automatic selection on the files only works after clicking once in a free area of the file view. This does not work when the view has scrollbars and filled with files without free area. Files are focussed then but not selected. Even a workaround by right click, closing context menu makes one file selected but automatic selection still does not work. This is required for selecting a range of files using Shift button.
Comment 1 Jim 2018-02-20 09:51:38 CET
I can confirm this but testing on 1.6.13 it happens with both single and double selected in Preferences.

It occurs for whatever "View as" option in View is selected. However if the option is changed after selecting the directory in the left pane it will work.
Comment 2 alexxcons editbugs 2018-02-20 23:27:45 CET
Thanks for reporting !
I can confirm the bug as well for master
Comment 3 Andre Miranda editbugs 2018-02-24 23:26:40 CET
An straightforward way to fix this is to not allow the tree view pane to steal file view's focus. It's fairly easy to preview this behavior:
- pkill -i thunar
- GTK_DEBUG=interactive thunar
- Select the ThunarTreeView, on its properties set can-focus to FALSE

It will be an one-liner fix, but I wonder if other users will complain about not being able to navigate on the side pane with the keys anymore.

Also, I think it's not easy to make select by hover work without focus, you see, Thunar uses ExoIconView and ExoTreeView, but explicitly check the widget's focus:
https://git.xfce.org/xfce/exo/tree/exo/exo-icon-view.c?id=d692d42567147570a25ea7136bf8c59f9fa97cf7#n8565
https://git.xfce.org/xfce/exo/tree/exo/exo-tree-view.c?id=d692d42567147570a25ea7136bf8c59f9fa97cf7#n655
Comment 4 Massimo Burcheri 2019-02-26 08:38:27 CET
Issue still valid for Thunar 1.8.4.
Comment 5 Git Bot editbugs 2020-05-26 23:34:35 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/190.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14233

Reported by:
Massimo Burcheri
Reported on: 2018-02-20
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Attachments

Additional information