! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Progress bar provides no info on deletion
Status:
RESOLVED: FIXED

Comments

Description mirh 2017-12-19 14:27:09 CET
"Preparing..."
Then when it finished after whatever time it takes, window closes.
Comment 1 Andre Miranda editbugs 2017-12-19 15:54:51 CET
Would you care to elaborate?
Comment 2 mirh 2017-12-19 20:12:16 CET
Created attachment 7502 
Dialog I'm talking about

When you are coping/moving files the dialog has the bar properly progressing. 
When you delete stuff instead, that's everything you'll ever get.
Comment 3 Andre Miranda editbugs 2017-12-22 02:19:27 CET
I see. Tracking down this issue, I found the _thunar_io_jobs_unlink function, its name is misleading, but it's responsible for files deletion. I didn't see in it any indication that it updates the progress dialog.
Needs more investigation...
Comment 4 Andre Miranda editbugs 2018-06-08 04:15:03 CEST
*** Bug 14435 has been marked as a duplicate of this bug. ***
Comment 5 Andre Miranda editbugs 2018-07-23 00:49:49 CEST
Created attachment 7845 
Fix patch

Finally I found some time to investigate this issue.
Surprisingly it's was rather easy, it seems the previous maintainers forgot a couple of lines while migrating from thunar-vfs to gio.
Comment 6 Git Bot editbugs 2018-07-29 22:53:04 CEST
Andre Miranda referenced this bugreport in commit e332e1e7421e135fd3d51771e857897a1da3e41e

Update progress when deleting files (Bug #14102)

https://git.xfce.org/xfce/thunar/commit?id=e332e1e7421e135fd3d51771e857897a1da3e41e
Comment 7 Git Bot editbugs 2018-07-29 22:54:07 CEST
Andre Miranda referenced this bugreport in commit 86b7f752c88ec413f11b268a16af4ee8df213811

Update progress when deleting files (Bug #14102)

https://git.xfce.org/xfce/thunar/commit?id=86b7f752c88ec413f11b268a16af4ee8df213811
Comment 8 Andre Miranda editbugs 2018-07-29 22:56:29 CEST
Fixed, it will be available in the next 1.8.x release.
Thanks for reporting.
Comment 9 mirh 2018-07-30 21:36:17 CEST
It's fixed in -git, thanks. 

Though it still misses any kind of "time estimation" (still unlikely copy)
Comment 10 Git Bot editbugs 2018-08-10 03:34:21 CEST
Andre Miranda referenced this bugreport in commit f61844b6c18e7d9a9c46c4f2ccde68cab7d5ff13

Show numeric(%) progress in file operation dialog (Bug #14102)

https://git.xfce.org/xfce/thunar/commit?id=f61844b6c18e7d9a9c46c4f2ccde68cab7d5ff13
Comment 11 Git Bot editbugs 2018-08-10 03:34:43 CEST
Andre Miranda referenced this bugreport in commit 667e1e10a25bb8a23dea685a89e6e775c7b430c9

Show numeric(%) progress in file operation dialog (Bug #14102)

https://git.xfce.org/xfce/thunar/commit?id=667e1e10a25bb8a23dea685a89e6e775c7b430c9
Comment 12 Andre Miranda editbugs 2018-08-10 03:46:46 CEST
In order to add time estimation, we would need to use ThunarTransferJob instead of ThunarSimpleJob, too much work for little benefit. I'm more interested in optimizing the delete operation so time estimation won't be necessary.
Comment 13 mirh 2018-08-10 21:57:39 CEST
I appreciate the making it faster and percentage (the "empty space" on the bottom at least feels meaningful) things. 
But this asymmetry between copy and deletion still feels off and a missing feature. 

Besides, I mean.. Even 100/Δ%*s could be already called a day under some pov.

Bug #14102

Reported by:
mirh
Reported on: 2017-12-19
Last modified on: 2018-08-10
Duplicates (1):
  • 14435 "preparing to delete" dialog does not update when deleting a large amount of files.

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
1.6.13

Attachments

Dialog I'm talking about (9.35 KB, image/png)
2017-12-19 20:12 CET , mirh
no flags
Fix patch (1.00 KB, patch)
2018-07-23 00:49 CEST , Andre Miranda
no flags

Additional information