! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
cannot compile Thunar-volman-0.9.0 against xfce-4.12
Status:
RESOLVED: FIXED
Product:
Thunar-volman
Component:
General

Comments

Description Stefan Seyfried 2017-12-18 19:34:49 CET
Trying to update thunar-volman to 0.9.0 for openSUSE leads to the following compile warning:

main.c: In function 'main':
main.c:108:7: warning: implicit declaration of function 'xfce_widget_reparent'; did you mean 'gtk_widget_reparent'? [-Wimplicit-function-declaration]
       xfce_widget_reparent (plug_child, plug);
       ^~~~~~~~~~~~~~~~~~~~
       gtk_widget_reparent

and later during linking to the error:

thunar_volman_settings-main.o: In function `main':
main.c:(.text.startup+0x127): undefined reference to `xfce_widget_reparent'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:568: thunar-volman-settings] Error 1

...which does not suprise, since xfce_widget_reparent was only added with libxfce4ui 4.13.0
Comment 1 Stefan Seyfried 2017-12-18 20:01:09 CET
This was introduced by https://git.xfce.org/xfce/thunar-volman/commit/?id=0802ab0f4f942ebae0b39f56d5463a3378e5630d, adding author to cc
Comment 2 Andre Miranda editbugs 2017-12-18 20:16:22 CET
Yes, I forgot to mention that this release targets Xfce 4.13+, but it should be trivial to add support to 4.12. I'll give it a try later. Thanks for reporting.
Comment 3 Git Bot editbugs 2017-12-24 01:45:27 CET
Andre Miranda referenced this bugreport in commit 63b918db8c0dcf85aee3f9761293942fa083d7a6

Allow compilation against libxfce4ui 4.12 (Bug #14100)

https://git.xfce.org/xfce/thunar-volman/commit?id=63b918db8c0dcf85aee3f9761293942fa083d7a6
Comment 4 Andre Miranda editbugs 2017-12-24 01:46:04 CET
Fixed in master, will be available in 0.9.1.

Bug #14100

Reported by:
Stefan Seyfried
Reported on: 2017-12-18
Last modified on: 2017-12-24

People

Assignee:
Andre Miranda
CC List:
2 users

Version

Attachments

Additional information