! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar-volman mounts non-removable devices
Status:
RESOLVED: MOVED
Product:
Thunar-volman
Component:
General

Comments

Description Stefan Seyfried 2017-12-10 12:33:00 CET
Created attachment 7480 
patch to only trigger on removable devices

for details, see also: https://bugzilla.opensuse.org/show_bug.cgi?id=949808

User runs "losetup $file.iso" and gets prompted to mount the iso file.

I created a quick patch which does check for udisks hints (but these are no longer available with udisks2) or if they are missing goes into sysfs and looks for the "removable" flag of the device and only triggers volman if the device is a removable one.

Patch is attached.

This patch is being shipped in openSUSE Tumbleweed (rolling release) right now, I'll submit it as an maintenance update to openSUSE Leap 42.3 soon.
Comment 1 Andre Miranda editbugs 2018-09-22 23:23:53 CEST
Hi Stefan,
I never used losetup before, after researching a bit I was able to mount an iso like this:
# reminder to myself (necessary only on Arch Linux):
sudo modprobe loop
sudo losetup /dev/loop0 foo.iso

In volman, "Mount removable drives when hot-plugged" is enabled but nothing happens (as not expected by this bug report).
Am I missing anything?

By the way, sorry for the very long time it took to someone review your patch.
Comment 2 Git Bot editbugs 2020-05-25 23:11:43 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar-volman/-/issues/15.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14075

Reported by:
Stefan Seyfried
Reported on: 2017-12-10
Last modified on: 2020-05-25

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Attachments

Additional information