! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar-1.7.0 crash by right-click
Status:
RESOLVED: INVALID
Priority:
Very High

Comments

Description onkelho 2017-12-10 10:44:31 CET
all core packages are built by the git-core master's from 09th december.
No compilation-errors.
But when I make a right-click in Thunar, he crashes.
The version 1.6.13, however, does not seem to have this problem, but will continue with a patch: "Patch4: 0004-thunar-1.5.0-dont-die-on-dbus-disconnect.patch"
Of course, this patch can not be used in the 1.7.0, but it seems to be exactly the problem that separates dbus the connection and Thunar is not free to act thereby.
the patch for 1.6....
"
--- thunar/thunar-dbus-service.c.orig	2012-10-14 15:01:38.000000000 +0200
+++ thunar/thunar-dbus-service.c	2012-10-15 21:02:39.000000000 +0200
@@ -292,6 +292,9 @@
       /* once we registered, unset dbus variables (bug #8800) */
       g_unsetenv ("DBUS_STARTER_ADDRESS");
       g_unsetenv ("DBUS_STARTER_BUS_TYPE");
+
+      /* don't die on dbus disconnect */
+      dbus_connection_set_exit_on_disconnect(dbus_service->connection, FALSE);
     }
   else
     {
"
on all 1.6... versions work stable

How can implement a function to make thunar independed on the dbus-status?
I am only a packager, not so good in coding.
Best Regards
Comment 1 alexxcons editbugs 2017-12-10 22:47:27 CET
Thanks for the report! 

So you tested thunar 1.6 with/without patch, and it as well crashed without patch, like 1.7 ?

... probably there is some  gdbus equivalent for dbus_connection_set_exit_on_disconnect() ... need to check that.

However still need to figure out why this crash occurs at all for you. Possibly you have some old thunar-plugin installed ? ( Thunarx, the thunar-plugin API changed .. possibly that has consequences for the right-click menu )

Please note that 1.7 is a development release! E.g. there is as well a bug which will cause thunar1.7 to die silently if a thunar 1.6 daemon is still running, fixed in master (https://git.xfce.org/xfce/thunar/commit/?id=ad8663a45b55797e3cd7e1b8ade1cef258c91d3c), but not in 1.7. 
So maybe better wait till 1.8 before packaging things.
Comment 2 Andre Miranda editbugs 2017-12-24 00:09:37 CET
I assume the issue was caused by an incompatible plugin. Clean <prefix>/thunarx-3 and try with the latest source from master, if the problem persists, please reopen and provide the crash backtrace.
And as Alex pointed out, 1.7.0 is a development release, not meant for end users.
Comment 3 onkelho 2017-12-25 11:15:06 CET
i will try do something suggested here, but now i must rebuild my xfce-core-packages,
e.g. lib64exo-devel is not enable to install on newer updated distribution-packages
... please keep patience ...
Comment 4 onkelho 2018-01-02 18:35:16 CET
i must say "excuse me please", i can't recover what's matter are...
now i used a installation from a iso of 08Aug2017 and make a full update 
on pclinuxos-packages and install my builds of xfce-core-packages and what i should 
tell your, all works, Thunar-1.7.0 not crash anymore
i am happy and wish all developers on xfce.org a very nice 2018
shame on me that's i found not the failure of my older install

Bug #14074

Reported by:
onkelho
Reported on: 2017-12-10
Last modified on: 2018-01-02

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Attachments

Additional information