! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix enumeration libraries in libxfdashboard.pc
Status:
RESOLVED: FIXED
Product:
Xfdashboard
Component:
General

Comments

Description Olivier Duchateau 2017-09-15 22:53:02 CEST
Created attachment 7318 
Fix enumeration libraries in libxfdashboard.pc

With the latest commit, clutter-gdk-1.0 is added in libxfdashboard.pc even if GDK backend is not found. Patch fixes this issue.

clutter-gdk-1.0 and clutter-1.0 import same libraries (checked on Fedora 26) so I think one of them is enough.

pkgconf --libs clutter-1.0
-lclutter-1.0 -lglib-2.0 -lcogl-path -lglib-2.0 -lglib-2.0 -latk-1.0 -lcogl-pango -lglib-2.0 -lcogl -lgmodule-2.0 -pthread -lglib-2.0 -lwayland-egl -lgbm -ldrm -lEGL -lXrandr -ljson-glib-1.0 -lgio-2.0 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lgdk_pixbuf-2.0 -lcairo-gobject -lcairo -lgobject-2.0 -lglib-2.0 -lwayland-cursor -lwayland-client -lxkbcommon -lwayland-server -lX11 -lXext -lXdamage -lXfixes -lXcomposite -lXi

pkgconf --libs clutter-gdk-1.0
-lclutter-1.0 -lglib-2.0 -lcogl-path -lglib-2.0 -lglib-2.0 -latk-1.0 -lcogl-pango -lglib-2.0 -lcogl -lgmodule-2.0 -pthread -lglib-2.0 -lwayland-egl -lgbm -ldrm -lEGL -lXrandr -ljson-glib-1.0 -lgio-2.0 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lgdk_pixbuf-2.0 -lcairo-gobject -lcairo -lgobject-2.0 -lglib-2.0 -lwayland-cursor -lwayland-client -lxkbcommon -lwayland-server -lX11 -lXext -lXdamage -lXfixes -lXcomposite -lXi
Comment 1 Git Bot editbugs 2017-09-18 16:16:23 CEST
Stephan Haller referenced this bugreport in commit 1fb678329b4aeff5e8cabb7458eefa7e3670a0ca

Fix building list of libraries depending on when checking for Clutter version and its supported backend

https://git.xfce.org/apps/xfdashboard/commit?id=1fb678329b4aeff5e8cabb7458eefa7e3670a0ca
Comment 2 Stephan Haller editbugs 2017-09-18 16:19:24 CEST
Thank for the patch. I only added a line to include clutter-gdk-1.0 to the list of required packages if GDK backend was found. I don't like to rely on assumptions that both packages (clutter-1.0 and clutter-gdk-1.0) will always refer to the same packages (in number and names). Therefore clutter-gdk-1.0 is added in addition to clutter-1.0, even if it doubles the required packages.

Closing bug and thanks :)

Bug #13860

Reported by:
Olivier Duchateau
Reported on: 2017-09-15
Last modified on: 2017-09-18

People

Assignee:
Stephan Haller
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information