! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
"Draw frame around selected windows while cycling" does not draw if previousl...
Status:
RESOLVED: MOVED

Comments

Description jspenguin 2017-07-28 18:44:30 CEST
Created attachment 7244 
frame.patch

On one of my virtual desktops, I have 4 identically-sized Xterm windows. When I cycle through the windows with Alt-Tab, the first window gets outlined, but when I press Tab again, the next window does not get outlined. If I open a window that is a different size, then it gets outlined as I cycle through.

I looked through the source code and found the following suspicious block of code in src/wireframe.c:

    if ((width == wireframe->width) && (height == wireframe->height))
    {
        /* Moving only */
        return;
    }

I removed this block, and that fixed the bug for me.
Comment 1 jspenguin 2017-07-28 18:45:42 CEST
Created attachment 7245 
Video showing behavior pre-patch
Comment 2 jspenguin 2017-07-28 18:47:21 CEST
Created attachment 7246 
Video showing correct behavior after patch
Comment 3 Git Bot editbugs 2020-05-29 12:17:56 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/269.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #13747

Reported by:
jspenguin
Reported on: 2017-07-28
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
4.12.0

Attachments

frame.patch (709 bytes, patch)
2017-07-28 18:44 CEST , jspenguin
no flags
Video showing behavior pre-patch (196.92 KB, video/x-matroska)
2017-07-28 18:45 CEST , jspenguin
no flags
Video showing correct behavior after patch (258.37 KB, video/x-matroska)
2017-07-28 18:47 CEST , jspenguin
no flags

Additional information