! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Ristretto misses DBUS_GLIB_CFLAGS and DBUS_GLIB_LIBS in the CFLAGS and LIBS l...
Status:
RESOLVED: DUPLICATE
Product:
Ristretto
Component:
Application

Comments

Description Ali Akcaagac 2017-06-27 16:50:54 CEST
Created attachment 7201 
Fix for subject issue.

Today I ran into an issue that ristretto wasn't able to find <dbus/dbus-glib.h>. Somehow this might be related that some other metapackage has provided inclusion of the missing libraries and include paths. Somehow after digging into the makefiles, I deteced that the DBUS* macros are resolved and found. But the Makefiles forgot to include them into the global list of CFLAGS and LDFLAGS. So it's detected but not embedded and thus not found.

The following patch solves the situation.
Comment 1 Skunnyk editbugs 2017-06-27 18:09:28 CEST
Thank you, but for your information, Ristretto is on the way to gdbus with #13679
Comment 2 Ali Akcaagac 2017-06-27 18:28:03 CEST
Yep! I'm aware of this. But needs to be fixed nonetheless.
Comment 3 Ali Akcaagac 2017-06-27 19:57:54 CEST
Tried the patch from #13679 and that's definately the better choice (at least for my case). Thanks again for the hint.
Comment 4 Skunnyk editbugs 2017-06-28 18:51:13 CEST
Thank you for your tests. Hopefully the gdbus port will be merged soon :)
Comment 5 Igor editbugs 2017-07-10 01:39:05 CEST
I've just merged 13679.
Thanks for raising this up!

*** This bug has been marked as a duplicate of bug 13679 ***

Bug #13692

Reported by:
Ali Akcaagac
Reported on: 2017-06-27
Last modified on: 2017-07-10

People

CC List:
1 user

Version

Version:
master

Attachments

Fix for subject issue. (1.06 KB, patch)
2017-06-27 16:50 CEST , Ali Akcaagac
no flags

Additional information