! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
build-error by ...cell-render--- milestone-4.13-4.14 gtk+3.22...
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Settings Editor

Comments

Description onkelho 2017-06-07 16:11:16 CEST
...
  CCLD     xfce4-settings-editor
xfce4_settings_editor-xfce-settings-cell-renderer.o: In function `xfce_settings_array_type':
xfce-settings-cell-renderer.c:(.text+0xb02): undefined reference to `dbus_g_type_get_collection'
collect2: error: ld returned 1 exit status
Makefile:612: recipe for target 'xfce4-settings-editor' failed
...
possible this will solving by remove older code - see link:
https://dbus.freedesktop.org/doc/dbus-glib/dbus-glib-Specializable-GType-System.html#dbus-g-type-get-collection

.."

dbus_g_type_get_collection is deprecated and should not be used in newly-written code.

New code should use GDBus instead.
"..

not knowing if this can help, but before 4.13.0 all was possible to build

if it's not usefull to debug, please excuse me
Comment 1 onkelho 2017-06-07 16:20:25 CEST
with option full-debug:
...
make[4]: Entering directory '/repm/src/Q2017/TEST/xfce4-settings-4.13.0/dialogs/appearance-settings'
  CC       xfce4_appearance_settings-main.o
main.c: In function ‘compute_xsettings_dpi’:
main.c:175:5: error: ‘gdk_screen_get_width_mm’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:62) [-Werror=deprecated-declarations]
     width_mm = gdk_screen_get_width_mm (screen);
     ^
main.c:176:5: error: ‘gdk_screen_get_height_mm’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:64) [-Werror=deprecated-declarations]
     height_mm = gdk_screen_get_height_mm (screen);
     ^
main.c:181:9: error: ‘gdk_screen_get_width’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:58) [-Werror=deprecated-declarations]
         width = gdk_screen_get_width (screen);
         ^
main.c:182:9: error: ‘gdk_screen_get_height’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:60) [-Werror=deprecated-declarations]
         height = gdk_screen_get_height (screen);
         ^
cc1: all warnings being treated as errors
Makefile:672: recipe for target 'xfce4_appearance_settings-main.o' failed
make[4]: *** [xfce4_appearance_settings-main.o] Error 1
make[4]: Leaving directory '/repm/src/Q2017/TEST/xfce4-settings-4.13.0/dialogs/appearance-settings'
Makefile:520: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory '/repm/src/Q2017/TEST/xfce4-settings-4.13.0/dialogs/appearance-settings'
Makefile:492: recipe for target 'all-recursive' failed

...
Comment 2 onkelho 2017-06-08 10:51:00 CEST
now with clean tarball and with actual git today:
""
]$ make
make  all-recursive
make[1]: Entering directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0'
Making all in dialogs
make[2]: Entering directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0/dialogs'
Making all in appearance-settings
make[3]: Entering directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0/dialogs/appearance-settings'
make  all-am
make[4]: Entering directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0/dialogs/appearance-settings'
  CC       xfce4_appearance_settings-main.o
main.c: In function ‘compute_xsettings_dpi’:
main.c:175:5: error: ‘gdk_screen_get_width_mm’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:62) [-Werror=deprecated-declarations]
     width_mm = gdk_screen_get_width_mm (screen);
     ^
main.c:176:5: error: ‘gdk_screen_get_height_mm’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:64) [-Werror=deprecated-declarations]
     height_mm = gdk_screen_get_height_mm (screen);
     ^
main.c:181:9: error: ‘gdk_screen_get_width’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:58) [-Werror=deprecated-declarations]
         width = gdk_screen_get_width (screen);
         ^
main.c:182:9: error: ‘gdk_screen_get_height’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkscreen.h:60) [-Werror=deprecated-declarations]
         height = gdk_screen_get_height (screen);
         ^
cc1: all warnings being treated as errors
Makefile:672: recipe for target 'xfce4_appearance_settings-main.o' failed
make[4]: *** [xfce4_appearance_settings-main.o] Error 1
make[4]: Leaving directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0/dialogs/appearance-settings'
Makefile:520: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0/dialogs/appearance-settings'
Makefile:492: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0/dialogs'
Makefile:546: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/repm/src/Q2017/TEST/xfce4-settings-xfce4-settings-4.13.0'
Makefile:478: recipe for target 'all' failed
make: *** [all] Error 2

""
Comment 3 onkelho 2017-06-08 11:50:10 CEST
in the ... /xfce4-settings/dialogs/appearance-settings/main.c   (so edit also in .h)
from line 166 on:
""
static int
compute_xsettings_dpi (GtkWidget *widget)
{
    GdkScreen *screen;
    int width_mm, height_mm;
    int width, height;
    int dpi;

    screen = gtk_widget_get_screen (widget);
    width_mm = gdk_screen_get_width_mm (screen);
    height_mm = gdk_screen_get_height_mm (screen);
    dpi = FALLBACK_DPI;

    if (width_mm > 0 && height_mm > 0)
    {
        width = gdk_screen_get_width (screen);
        height = gdk_screen_get_height (screen);
        dpi = MIN (INCH_MM * width  / width_mm,
                   INCH_MM * height / height_mm);
    }

    return dpi;
}
""
the "gdk_screen_get_width_mm" is deprecated since gtk+3.22
must rewrite with "gdk_monitor_get_width_mm ()" --- see https://developer.gnome.org/gdk3/stable/GdkMonitor.html#gdk-monitor-get-geometry

Regards
Comment 4 Skunnyk editbugs 2017-06-09 19:31:28 CEST
That is because you are compiling against xfconf 4.13.x, which is a port from dbus-glib to gdbus, and xfce4-settings is not yet compatible (see for example https://mail.xfce.org/pipermail/xfce4-dev/2017-June/031959.html ). Please use xfconf 4.12.1 for now.

About your debug build, in debug mode deprecated declaration are treated as error, that's why it fail. ( -Werror=deprecated-declarations )
Comment 5 onkelho 2017-06-13 15:39:15 CEST
today's git build works without errors with compiling against xfconf-4.13.x (also today actual from git) 
THX
Comment 6 Skunnyk editbugs 2017-06-25 22:50:53 CEST
Closing

Bug #13625

Reported by:
onkelho
Reported on: 2017-06-07
Last modified on: 2017-06-25

People

Assignee:
Jérôme Guelfucci
CC List:
1 user

Version

Version:
4.13.0

Attachments

Additional information