! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
feature: 'tab' should do 'tab completion' in 'toolbar style'
Status:
CLOSED: FIXED
Severity:
critical

Comments

Description lucius 2006-01-23 17:41:25 CET
Hitting 'tab' should do 'tab completion' instead of switching to the next
widget, when pressed in the adress bar ('toolbar style').

That's what a shell user would expect it to do...



Reproducible: Always
Steps to Reproduce:
1. 
2. 
3.
Comment 1 Benedikt Meurer editbugs 2006-01-23 18:41:35 CET
Created attachment 406 
Tab completion fix

The attached patch should fix the problem. Please verify.
Comment 2 lucius 2006-01-23 19:55:33 CET
(In reply to comment #1)
> Created an attachment (id=406) [edit]
> Tab completion fix
> 
> The attached patch should fix the problem. Please verify.

That was quick! The patch works fine. 

I still have one gripe about it, though: When the file selection is still
ambiguous, pressing 'tab' will still make the focus jump to the next widget.
Example:  if i have two files 'bla' and 'bli' in my home directory, entering
'/home/luzi/bl' and hitting 'tab' will make it jump. I think it should rather do
nothing (except show the files in question, as it does already).
Comment 3 Benedikt Meurer editbugs 2006-01-24 17:05:25 CET
Uhm, this is kinda tricky with the way the entry completion works in Gtk+. I'll
try to come up with a patch.
Comment 4 Benedikt Meurer editbugs 2006-01-25 16:53:27 CET
Ok, located the problem. The entry widget loses the focus once the popup window
appears, and so we cannot catch the tab key using the entry widget. The popup
window is controlled by GtkEntryCompletion and there's no way to add a keyboard
hook to that window, since it's completely hidden from the application.

My preferred solution would be to disable the popup window for the location bar
entry widget completely (similar to what Nautilus does). Unfortunately, there's
currently a bug in Gtk+, which prevents us from using this solution (see
http://bugzilla.gnome.org/show_bug.cgi?id=328610). Once the Gtk+ people apply
the patch, we can use that solution. Would that solve your issues?
Comment 5 Benedikt Meurer editbugs 2006-02-06 00:27:19 CET
Committed revision 19751.

2006-02-06	Benedikt Meurer <benny@xfce.org>

	* thunar/thunar-path-entry.c: Make sure to catch the tab key even for
	  the ThunarLocationEntry case. This doesn't work if the completion list
	  is visible, tho (Gtk+ bug/limitation). Bug #1346.
Comment 6 Benedikt Meurer editbugs 2006-02-06 00:27:57 CET
I'm closing this bug for now. Please re-open or file a new bugreport if there's
still something we can do for you. ;-)
Comment 7 Benedikt Meurer editbugs 2006-02-13 11:10:57 CET
*** Bug 1455 has been marked as a duplicate of this bug. ***

Bug #1346

Reported by:
lucius
Reported on: 2006-01-23
Last modified on: 2009-07-17
Duplicates (1):
  • 1455 Tab complete shifts focus when more than one completion is possible

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
0.2.1svn

Attachments

Tab completion fix (2.78 KB, patch)
2006-01-23 18:41 CET , Benedikt Meurer
no flags

Additional information