Created attachment 6995 Fix inconsistent icon directory for xc_crosshair With the latest release 1.2.0, the 16x16 xc_crosshair icon is located (after installation) in share/icons/hicolor/16x16/apps whereas others are located in actions/. Patch fixes this issue.
Thanks, applied
Im puzzled now at which one is the correct subdir - with your patch applied, at runtime it complains: (xfce4-taskmanager:10658): Gtk-WARNING **: Could not load a pixbuf from icon theme. This may indicate that pixbuf loaders or the mime database could not be found. and the icon isnt shown i nthe window. So maybe it should be the other way round ? Simon ?
For me, xc_crosshair icon is never displayed even if it's located in apps/ or actions/ directory. I use this [1] workaround (for FreeBSD users). [1] https://svnweb.freebsd.org/ports/head/x11/xfce4-taskmanager/files/patch-src_process-window.c?annotate=433953&pathrev=433953
Created attachment 7006 Usinf GIcon struct New patch, which uses GIcon struct instead of gchar. Now xc_crosshair icon is well displayed. No doubt, patch can be improved.
Created attachment 7007 Using GIcon struct instead of gchar Fix couple of warnings
Something is probably wrong, we shouldnt need all this - looping over system icon dirs is done automagically in all cases.
The GIcon patch is far too complicated, Gtk+ should be able to look up the icon in the currently selected theme (and all themes should by default fall back to hicolor) automatically. It also works for me here when I locally install taskmanager (even before the apps->actions patch was applied), so this may be a packaging issue.
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-taskmanager/-/issues/12. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev