! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Patch provided] Build without polkit fails on git master
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
major
Product:
Xfce4-session
Component:
General

Comments

Description flo.xfce 2017-02-04 23:42:27 CET 
Created attachment 6982 
Fix the build

Compilation without polkit fails because of a too soon closed #if clause. The attached patch fixes the build.
Comment 1 flo.xfce 2017-02-05 16:32:52 CET 
Created attachment 6983 
Fix the build V2

I was too quick with the first patch. The screensaver object is not tied to polkit and should be freed in all cases.
Comment 2 Eric Koegel editbugs 2017-03-04 03:21:31 CET 
Thanks! Pushed to master in:

commit 6a59c945b5b4dc7e7581616c9375c6e8d7a73d20
Author: flo <flo.xfce@gmx-topmail.de>
Date:   Sat Mar 4 05:19:05 2017 +0300

    Fix building without polkit
https://git.xfce.org/xfce/xfce4-session/commit/?id=6a59c945b5b4dc7e7581616c9375c6e8d7a73d20

Bug #13333

Reported by:
flo.xfce
Reported on: 2017-02-04
Last modified on: 2017-03-04

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
Unspecified
Target Milestone:
Xfce 4.12

Attachments

Fix the build (480 bytes, patch)
2017-02-04 23:42 CET , flo.xfce 		no flags
Fix the build V2 (447 bytes, patch)
2017-02-05 16:32 CET , flo.xfce 		no flags

Additional information