12964 – Can't compile against gtk 3.14

Can't compile against gtk 3.14

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfce4-battery-plugin

Component:

General

Comments

Description Timo Metsälä 2016-11-15 09:24:24 CET

I can't compile battery-plugin against gtk 3.14 (which is in Debian stable where I need to backport this to) because of an undeclared symbol

battery.c:619:43: error: 'widget' undeclared (first use in this function)
     gtk_widget_override_background_color (widget, GTK_STATE_FLAG_NORMAL, color);
                                           ^
is the intention to use 

GTK_WIDGET (battmon->battstatus)

instead of widget?

Comment 1 Landry Breuil editbugs

2016-11-20 21:07:54 CET

Myeah, probably a mistake on my side. will try to look into that, but i dont have a box with 3.14 anymore.

Comment 2 Andre Miranda editbugs

2016-11-30 20:53:11 CET

Landry, most likely my fault in b2985f36. I guess Timo's suggestion does the trick, I'll try it in a VM running GTK 3.14 as soon as possible, but don't hold your breath, feel free to push a commit if you will.

Comment 3 Landry Breuil editbugs

2016-12-01 11:25:17 CET

Fixed in 2c31c34

Comments

Bug #12964

People

Version

Attachments

Additional information