12663 – xfbib-file-io.c:86]: (style) Suspicious condition

xfbib-file-io.c:86]: (style) Suspicious condition

Status:

RESOLVED: WONTFIX

Priority:
Medium

Severity:
normal

Product:
Xfbib

Component:

General

Comments

Description David Binderman 2016-06-25 18:25:34 CEST

xfbib-file-io.c:86]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

        if ((ret = gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK)) {

Maybe better code

        if ((ret = gtk_dialog_run(GTK_DIALOG(dialog))) == GTK_RESPONSE_OK) {

Comment 1 Skunnyk editbugs

2018-09-22 16:44:23 CEST

This project has been archived, so we are closing related bugs.

Comments

Bug #12663

People

Version

Attachments

Additional information