! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
backlight_helper_get_best_backlight(): Find the right /sys/class/backlight in...
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description Jack Bates 2016-04-27 17:24:20 CEST
Created attachment 6657 
Use the kernel-supplied backlight type rather than a whitelist

This is a patch to replace the list of interfaces in backlight_helper_get_best_backlight() with the same logic as here:
https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/power/gsd-backlight-linux.c#n61

i.e. grab the first interface of type "firmware" and fall back on the first interface of type "platform" and finally "raw".

Here's the commit that replaced the list of interfaces in the GNOME source, and the rationale:
https://git.gnome.org/browse/gnome-settings-daemon/commit/plugins/power/gsd-backlight-helper.c?id=fff09fe17eecb9314962d119a5c5b4e865f2570d

I tested it on my machine (Eee PC 1201N) and it works.
Here's someone with the same problem on different hardware:
http://forum.xfce.org/viewtopic.php?id=9547
Comment 1 Eric Koegel editbugs 2016-05-24 14:03:24 CEST
Thanks for the patch, pushed to master in:
http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=36b2c96e91feeb118a4e8170c5d608795f00d5f2
Comment 2 Jack Bates 2016-05-24 22:06:35 CEST
Thanks!

Bug #12553

Reported by:
Jack Bates
Reported on: 2016-04-27
Last modified on: 2016-05-24

People

Assignee:
Ali Abdallah
CC List:
3 users

Version

Attachments

Additional information