! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
hexadecimal output and other improvements
Status:
RESOLVED: FIXED
Product:
Xfce4-calculator-plugin
Component:
General

Comments

Description Wim Hueskes 2016-04-19 14:46:38 CEST
This adds an option to show the result of a calculation in hexadecimal format. But while I was looking into it, I also added some more improvements.
I split them into 6 commits, but if it is easier, I can also squash them into a single commit. I will attach the diffs to this ticket, but you can also add https://github.com/wimh/xfce4-calculator-plugin.git as remote repo (branch dev).

I will be happy to answer any questions. But I will add some comments about the changes anyway;

https://github.com/wimh/xfce4-calculator-plugin/commit/7c9838623dde11068fe3d08750613371596e1a15 autogen.sh contained code to generate the revision from svn. As git is used now, this can be removed.

https://github.com/wimh/xfce4-calculator-plugin/commit/53c7dbf6ba0682bb97b311ea3314c52b8130c42c generate changelog from git log. A changelog does not seem useful to me if it is not updated. If this can be done automatically, I think everybody is happy...

https://github.com/wimh/xfce4-calculator-plugin/commit/c0263d4d190bdc2df491abb40a8b84cee7e8dd62 move test scripts (make check) to separate directory

https://github.com/wimh/xfce4-calculator-plugin/commit/824c13856ce358216e94d7f4c0cc19d4c09134bc adds tests for existing operations

https://github.com/wimh/xfce4-calculator-plugin/commit/e2d629f841375f73c58fcc2fd506bcdb8740ac0e add modulo operator. Note this will make it more difficult if a percent operator (33+10%) will be added in the future.

https://github.com/wimh/xfce4-calculator-plugin/commit/bb25e1581ce9f230eb5a82ce1e84e36cbc72a632 This adds an option to display hexadecimal output. I am not sure if the #ifdef conflicts with any coding conventions. 

Note I did not update the version number (yet).
Comment 1 Wim Hueskes 2016-04-19 14:48:02 CEST
Created attachment 6649 
subversion not used any more for revision
Comment 2 Wim Hueskes 2016-04-19 14:50:33 CEST
Created attachment 6650 
Generate Changelog from git log
Comment 3 Wim Hueskes 2016-04-19 14:51:27 CEST
Created attachment 6651 
move test scripts to tests subdirectory
Comment 4 Wim Hueskes 2016-04-19 14:51:59 CEST
Created attachment 6652 
add more tests
Comment 5 Wim Hueskes 2016-04-19 14:52:31 CEST
Created attachment 6653 
add modulo (%) operator
Comment 6 Wim Hueskes 2016-04-19 14:53:20 CEST
Created attachment 6654 
add hexadecimal output option
Comment 7 Roland Kübert editbugs 2016-04-22 12:06:41 CEST
Thanks for the patches, I'll have a look, but it will take some time.

Cheers

Roland
Comment 8 Roland Kübert editbugs 2016-06-20 22:44:20 CEST
Thanks for the patches, included all of them and bumped the plugin's version to 0.6.0 - release will be following shortly. :)

Bug #12548

Reported by:
Wim Hueskes
Reported on: 2016-04-19
Last modified on: 2016-06-20

People

Assignee:
Roland Kübert
CC List:
0 users

Version

Version:
unspecified

Attachments

subversion not used any more for revision (693 bytes, patch)
2016-04-19 14:48 CEST , Wim Hueskes
no flags
Generate Changelog from git log (1.54 KB, patch)
2016-04-19 14:50 CEST , Wim Hueskes
no flags
move test scripts to tests subdirectory (6.98 KB, patch)
2016-04-19 14:51 CEST , Wim Hueskes
no flags
add more tests (13.26 KB, patch)
2016-04-19 14:51 CEST , Wim Hueskes
no flags
add modulo (%) operator (3.91 KB, patch)
2016-04-19 14:52 CEST , Wim Hueskes
no flags
add hexadecimal output option (6.89 KB, patch)
2016-04-19 14:53 CEST , Wim Hueskes
no flags

Additional information