! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Missing tooltipp for nm-applet
Status:
RESOLVED: MOVED
Product:
Xfce4-indicator-plugin
Component:
General

Comments

Description Eberhard 2016-01-23 10:39:41 CET
The connection status tooltip for nm-applet is missing. 

I filed a proposal to add a tooltipp for nm-applet, but it turned out, that nm-applet does show a tooltip, which is missing only in xfce.

https://bugzilla.gnome.org/show_bug.cgi?id=760009 

It seems that xfce4-indicator-plugin is absorbing the tooltip.
Comment 1 Andrzej editbugs 2016-02-07 11:12:50 CET
Does it work with the "classic" systray (desktop notifications plugin with the indicator plugin removed from the Xfce panel)?

Does it work in Ubuntu (Unity desktop)?

There may be some features that are not supported by the Unity indicator API. If (1) works but (2) doesn't that could be the case. If (2) works this could indeed be an issue with the indicator plugin itself.
Comment 2 Viktor Odintsev editbugs 2017-06-17 02:38:38 CEST
Created attachment 7179 
patch to add tooltip support

XDG StatusNotifierItem supports ToolTip field. But libappindicator doesn't. It supports IconAccessibleDesc instead as a part of indicator icon:

> app_indicator_set_icon_full (applet->app_indicator, icon_name, applet->tip);

So I think this description can be used as tooltip text. This field is available in IndicatorObjectEntry. I'm attaching a patch which should add support for these tooltips. nm-applet shows it for me.
Comment 3 Viktor Odintsev editbugs 2017-06-17 09:48:03 CEST
(In reply to Viktor Odintsev from comment #2)
> Created attachment 7179 
> patch to add tooltip support

I've forgotten to add spaces in the top. Please fix it if you are going to apply the patch:
>-static gboolean             xfce_indicator_button_query_tooltip   (GtkWidget  *widget,
>+static gboolean             xfce_indicator_button_query_tooltip   (GtkWidget              *widget,
etc
Comment 4 Git Bot editbugs 2017-07-16 12:52:08 CEST
Viktor Odintsev referenced this bugreport in commit f01133757140d6ca42d3dff37394e19260897230

Bug 12417: Display tooltip for indicators

https://git.xfce.org/panel-plugins/xfce4-indicator-plugin/commit?id=f01133757140d6ca42d3dff37394e19260897230
Comment 5 Git Bot editbugs 2020-05-23 00:10:18 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-indicator-plugin/-/issues/9.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12417

Reported by:
Eberhard
Reported on: 2016-01-23
Last modified on: 2020-05-23

People

Assignee:
Andrzej
CC List:
1 user

Version

Version:
unspecified

Attachments

patch to add tooltip support (2.18 KB, patch)
2017-06-17 02:38 CEST , Viktor Odintsev
no flags

Additional information