12315 – 0.5.3 serious build warning — voidreturn

0.5.3 serious build warning — voidreturn

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
minor

Product:
Xfdashboard

Component:

General

Comments

Description Dmitriy A. Perlow 2015-11-15 21:13:13 CET

Hello!

openSUSE again :) 

[  195s] I: A function uses a 'return;' statement, but has actually a value
[  195s]    to return, like an integer ('return 42;') or similar.
[  195s] W: xfdashboard voidreturn /usr/include/glib-2.0/glib/gmessages.h:373

Comment 1 Stephan Haller editbugs

2015-11-16 09:43:08 CET

Hi,

I didn't get this message otherwise I had fixed it before the release ;)

Could you provide your build log to see where this issue is located?

Thanks
Stephan

Comment 2 Dmitriy A. Perlow 2015-11-16 17:01:01 CET

Created attachment 6534 
openSUSE_Tumbleweed/x86_64

%sha256sum xfdashboard-0.5.3.tar.bz2
a11625fec3e0ef61dbfd8c5af47df1dec55a92cbcaccba1f446058feeb629b4b  xfdashboard-0.5.3.tar.bz2

Gcc 5 as I see. No warnings with 4.8.

Comment 3 Stephan Haller editbugs

2015-11-17 09:49:31 CET

Thanks a lot. One error was already fixed but I found 4 more errors which I have fixed now.

If possible cherry-pick the following two commits from git and apply them. This should silence the compiler except for the deprecation warnings:

5aa475317aca2387cb6dcd15f3ab7fee1204a734
1d7811156ecb96f42d14ab145792c84042cca66b

Thanks
Stephan

Comment 4 Dmitriy A. Perlow 2015-11-17 23:28:56 CET

Thank you very much!

I'll do it (but I don't really know when, sorry) and I'll comment this ticket.

Comment 5 Dmitriy A. Perlow 2015-12-20 18:09:08 CET

0.5.4 is fine. Sorry for timeout.

Bug #12315

Reported by:
Dmitriy A. Perlow

Reported on: 2015-11-15
Last modified on: 2015-12-20

People

Assignee:
Stephan Haller

CC List:
0 users

Version

Version:
unspecified

Target Milestone:
---

Attachments

openSUSE_Tumbleweed/x86_64 (686.03 KB, text/plain)
2015-11-16 17:01 CET , Dmitriy A. Perlow

no flags

Additional information