! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Layout-labels shown in Unicode instead of local charset
Status:
RESOLVED: FIXED
Product:
Xfce4-xkb-plugin
Component:
General

Comments

Description Mikhail T. 2015-11-08 15:01:04 CET
Created attachment 6523 
Part of a screenshot showing garbled label

With the $LANG set to uk_UA.KOI8-U I get most of the interface of Xfce4 in Ukrainian, which is great.

But the xkb-plugin fails to convert its keyboard-layout labels from Unicode to KOI8-U, which results in perfectly unreadable (in any language) labels -- see attachment for an illustration.

One can still figure things out by the flags displayed, but not by the labels.
Comment 1 w@sp 2016-03-29 12:44:06 CEST
I have the same problem.
When do you plan to solve this problem?
Comment 2 Git Bot editbugs 2017-06-10 14:31:47 CEST
Viktor Odintsev referenced this bugreport in commit 36a6e59403cb9c9b9b51c46b8d6b9f065841c585

Bug 12294: Use local charset for layout names

https://git.xfce.org/panel-plugins/xfce4-xkb-plugin/commit?id=36a6e59403cb9c9b9b51c46b8d6b9f065841c585
Comment 3 w@sp 2017-06-10 16:22:31 CEST
Patch works for me.
Thanks!
Comment 4 Mikhail T. 2017-06-12 16:22:11 CEST
Created attachment 7167 
Version of the patch for 0.7.1

Victor's diff would not apply to 0.7.1 -- the last _released_ version of the XKB-plugin.

Here is, what I ended up applying instead -- and, yes, it does work for me too...
Comment 5 w@sp 2017-06-12 17:15:03 CEST
(In reply to Mikhail T. from comment #4)
> Created attachment 7167 
> Version of the patch for 0.7.1
> 
> Victor's diff would not apply to 0.7.1 -- the last _released_ version of the
> XKB-plugin.
> 
> Here is, what I ended up applying instead -- and, yes, it does work for me
> too...

I did my own patch for xfce4-xkb-plugin version 0.7.1 on FreeBSD, which was based on this patch :)
Comment 6 Mikhail T. 2017-06-12 20:05:09 CEST
(In reply to w@sp from comment #5)
> I did my own patch for xfce4-xkb-plugin version 0.7.1 on FreeBSD, which was
> based on this patch :)

Khm, "based on"? The file I posted came straight out of my own /usr/ports/deskutils/xfce4-xkb-plugin/files/  :) But I wanted to give Victor et al a chance to comment on the patch's validity

Will you file the FreeBSD PR -- to have the patch added to our port until a new release of the plugin is made available?.. Дякую...
Comment 7 w@sp 2017-06-12 20:15:54 CEST
(In reply to Mikhail T. from comment #6)

> Will you file the FreeBSD PR -- to have the patch added to our port until a
> new release of the plugin is made available?.. Дякую...

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215559

Waiting commit patch ...

P.S.
Будь ласка ;)
Comment 8 Viktor Odintsev editbugs 2017-06-12 21:01:20 CEST
(In reply to Mikhail T. from comment #6)
> But I wanted to give Victor et al a chance to comment on the patch's validity

Your patch seems correct and it should fix the problem on 0.7.1.

I'm going to release a new version soon.
Comment 9 Viktor Odintsev editbugs 2017-07-24 15:59:46 CEST
Fixed in 0.8.0

Bug #12294

Reported by:
Mikhail T.
Reported on: 2015-11-08
Last modified on: 2017-07-24

People

Assignee:
Azamat H. Hackimov
CC List:
3 users

Version

Attachments

Part of a screenshot showing garbled label (7.78 KB, image/png)
2015-11-08 15:01 CET , Mikhail T.
no flags
Version of the patch for 0.7.1 (811 bytes, patch)
2017-06-12 16:22 CEST , Mikhail T.
no flags

Additional information