! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Cursor position in icon view not visible/highlighted when using ctrl + arrows
Status:
RESOLVED: FIXED

Comments

Description lyngeled 2015-09-27 13:11:13 CEST
The bug appear when selecting multiple files by pressing and holding ctrl, then use arrows keys to move around and selecting files with the spacebar. The selected files is indicated by a colored background to the filename, but you can't see which file you are "placed on" when moved using ctrl and arrows keys. Normally this filename would have a lighter colored background.

Cheers
Comment 1 Andre Miranda editbugs 2015-12-03 18:23:15 CET
It might be related to your theme. I'm using Orion and the selected file has a dotted border, I can barely see it be, but helps.
Comment 2 alexxcons editbugs 2018-01-28 21:44:19 CET
Confirmed for Adwaita, Arc, Greybird ... as well for different dark themes using thunar master. There is not even a dotted border.

Not sure how to install orion theme in debian .. did not find any package :F

@Andre Miranda : Is the dotted border in orion still there for you in thunar-master ?
Comment 3 Andre Miranda editbugs 2018-02-12 19:41:21 CET
I not using Orion these days, but I've installed it just to check this out.
Here's a summary of how this bug is behaving for me:

Thunar 1.6.13 (gtk2):
  - Orion
    - Icons: no selector
    - Detailed List: light blue background
    - Compact List: no selector
  - Adwaita
    - light gray border on all views
  - Greybird
    - Icons: dotted line
    - Detailed List: light blue background
    - Compact List: dotted line

Thunar from master (gtk3):
  - Orion
    - no selector on all views
    - doesn't seem compatible with gtk3 at all, many other widgets are broken
  - Adwaita & Greybird
    - Icons: no selector
    - Detailed List: dotted line
    - Compact List: no selector

Well, the results contradicts my previous comment, probably something changed since then.
Comment 4 Theo Linkspfeifer editbugs 2020-02-20 13:09:10 CET
Moving to exo.
Comment 5 Theo Linkspfeifer editbugs 2020-02-20 13:22:05 CET
Created attachment 9475 
diff

I added a gtk_render_focus() call to the drawing routine in exo-icon-view to bring back the focus outline around icon labels (in both Thunar and xfce4-settings-manager). Maybe this could be fixed in another way though.
Comment 6 alexxcons editbugs 2020-02-22 18:03:33 CET
(In reply to Theo Linkspfeifer from comment #5)
> Created attachment 9475 
> diff
> 
> I added a gtk_render_focus() call to the drawing routine in exo-icon-view to
> bring back the focus outline around icon labels (in both Thunar and
> xfce4-settings-manager). Maybe this could be fixed in another way though.

Works fine for me, and patch IMO looks good to get pushed. thanks !

After that one got pushed, I guess we should open a bug on greybird ... e.g. in dolphin (probably I use the qt default theme) some light blue background makes the focused item more visible in that case.
Comment 7 Andre Miranda editbugs 2020-03-03 04:56:22 CET
The patch works well for me too, thanks Theo!
Before pushing to master, I would like to hear from Sean.
Comment 8 Git Bot editbugs 2020-03-22 00:22:42 CET
Theo Linkspfeifer referenced this bugreport in commit 8b7f6824fc50747d9b152ef0aa91bc28da0260e4

Cursor position in icon view not visible/highlighted when using ctrl + arrows (Bug #12227)

https://git.xfce.org/xfce/exo/commit?id=8b7f6824fc50747d9b152ef0aa91bc28da0260e4
Comment 9 alexxcons editbugs 2020-03-22 00:24:26 CET
pushed to master, in agreement with Sean.

Bug #12227

Reported by:
lyngeled
Reported on: 2015-09-27
Last modified on: 2020-03-22

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
unspecified

Attachments

diff (767 bytes, patch)
2020-02-20 13:22 CET , Theo Linkspfeifer
no flags

Additional information