! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
systemload-plugin/wrapper-1.0 crash on startup
Status:
RESOLVED: FIXED
Severity:
critical
Product:
Xfce4-systemload-plugin
Component:
General

Comments

Description Ian 2015-07-20 17:15:18 CEST
The systemload plugin crashes immediately upon being added to a panel. I'm using the official xfce4-systemload-plugin-1.1.2_1 package from the FreeBSD amd64 repositories.

Gdb output is below. Thanks!

- Ian


-- paste:

(gdb) bt full
#0  0x000000080922637a in up_client_glue_get_on_battery () from /usr/local/lib/libupower-glib.so.2
No symbol table info available.
#1  0x00000008084c141a in xfce_panel_module_construct () from /usr/local/lib/xfce4/panel/plugins/libsystemload.so
No symbol table info available.
#2  0x00000008084c05f0 in xfce_panel_module_construct () from /usr/local/lib/xfce4/panel/plugins/libsystemload.so
No symbol table info available.
#3  0x00000008084bf59f in xfce_panel_module_construct () from /usr/local/lib/xfce4/panel/plugins/libsystemload.so
No symbol table info available.
#4  0x0000000801c79912 in g_closure_invoke () from /usr/local/lib/libgobject-2.0.so.0
No symbol table info available.
#5  0x0000000801c8e87d in g_signal_emitv () from /usr/local/lib/libgobject-2.0.so.0
No symbol table info available.
#6  0x0000000801c8f308 in g_signal_emit_valist () from /usr/local/lib/libgobject-2.0.so.0
No symbol table info available.
#7  0x0000000801c8fa24 in g_signal_emit () from /usr/local/lib/libgobject-2.0.so.0
No symbol table info available.
#8  0x00000008010e1f75 in gtk_widget_realize () from /usr/local/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#9  0x00000008010e1d5a in gtk_widget_map () from /usr/local/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#10 0x0000000801c79b6a in g_closure_invoke () from /usr/local/lib/libgobject-2.0.so.0
No symbol table info available.
#11 0x0000000801c8efe6 in g_signal_emit_valist () from /usr/local/lib/libgobject-2.0.so.0
No symbol table info available.
#12 0x0000000801c8fa24 in g_signal_emit () from /usr/local/lib/libgobject-2.0.so.0
No symbol table info available.
#13 0x00000008010e14f0 in gtk_widget_show () from /usr/local/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#14 0x000000000040392f in main ()
No symbol table info available.
Comment 1 Landry Breuil editbugs 2015-07-21 15:03:55 CEST
is upowerd running on your system ? does upower -d yield something ?
Comment 2 Ian 2015-07-21 15:20:45 CEST
It doesn't appear that upower is running.

tsoh0715:~ % ps ax|grep power
21580  5  S+       0:00.00 grep power


tsoh0715:~ % upower -d

(upower:21581): libupower-glib-WARNING **: Couldn't connect to proxy: Could not connect: No such file or directory

(upower:21581): GLib-GIO-CRITICAL **: g_dbus_proxy_call_sync_internal: assertion 'G_IS_DBUS_PROXY (proxy)' failed


-- followed by a segfault --

#0  0x000000080082a7f6 in up_client_get_devices ()
   from /usr/local/lib/libupower-glib.so.2

(rest of backtrace is useless)
Comment 3 Landry Breuil editbugs 2015-07-21 15:33:37 CEST
two things then:

- you should figure out how to start upowerd (usually running a systemwide dbus session should be enough) on freebsd. Once started, the plugin *shouldnt* crash.

- the plugin should cope better with the absence of upowerd on D-BUS. I'll try to look into that.
Comment 4 Ian 2015-07-22 17:58:59 CEST
Thank you for pointing me in the right direction. Enabling dbus solves the issue. I believe that FreeBSD is trying to move away from hal/dbus as indicated in the handbook:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/x-config-quick-start.html

If you do have a chance to look into handling the absence of dbus it may suffice to simply check for dbus/upowerd and report it as a missing dependency on startup.

Cheers -
Ian
Comment 5 Landry Breuil editbugs 2015-07-22 21:16:35 CEST
(In reply to Ian from comment #4)
> Thank you for pointing me in the right direction. Enabling dbus solves the
> issue. I believe that FreeBSD is trying to move away from hal/dbus as
> indicated in the handbook:
> 
> https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/x-config-quick-
> start.html

I think you're mixing D-BUS & HAL here, since those days any 'advanced' DE relies on D-BUS. HAL itself is another story, and long dead :)
Comment 6 Skunnyk editbugs 2017-11-09 23:25:29 CET
Tested with latest systemload release (1.2.1) without upower running, and the crash does not occur anymore.
Comment 7 Landry Breuil editbugs 2017-11-10 22:34:42 CET
(In reply to Skunnyk from comment #6)
> Tested with latest systemload release (1.2.1) without upower running, and
> the crash does not occur anymore.

But have you tried on FreeBSD ? The trace is in up_client_get_devices which is in the os-specific code...
Comment 8 Skunnyk editbugs 2017-11-12 12:22:54 CET
Just tested on a freebsd 11.1 with xfce 4.12, systemoad 1.2.1, upower 0.99.4.
When I add the plugin to the panel, upower is automatically started and no crash occurs.
So I think the problem is gone ;)

Bug #12081

Reported by:
Ian
Reported on: 2015-07-20
Last modified on: 2019-04-22

People

Assignee:
Xfce-Goodies Maintainers
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information