! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
libxfce4util: make dist not possible because of non-existent Makefile hook
Status:
RESOLVED: FIXED
Product:
Libxfce4util
Component:
General

Comments

Description Oliver Lehmann 2005-11-01 12:32:07 CET
Hi,

try running "make dist" in libxfce4util (after the gtk-doc issue was solved
[#1204]). It will abort metioning that the hook dist-hook-local is undefined,
and indeed it is.

Reproducible: Always
Steps to Reproduce:
1. svn up
2. env NOCONFIGURE=1 autogen.sh
3. ./configure --enable-maintainer-mode --enable-gtk-doc
4. make dist

Actual Results:  
make  all-am
/usr/home/olivleh1/tmp/trunk/libxfce4util/install-sh -d
/usr/home/olivleh1/tmp/trunk/libxfce4util/libxfce4util-4.3.0svn-r18575/docs/..
make  
top_distdir="/usr/home/olivleh1/tmp/trunk/libxfce4util/libxfce4util-4.3.0svn-r18575"
distdir="/usr/home/olivleh1/tmp/trunk/libxfce4util/libxfce4util-4.3.0svn-r18575/docs"
 dist-hook
make: don't know how to make dist-hook-local. Stop
*** Error code 2

Stop in /usr/home/olivleh1/tmp/trunk/libxfce4util/docs.
*** Error code 1

Stop in /usr/home/olivleh1/tmp/trunk/libxfce4util.
Exit 1


Expected Results:  
successfull run of make dist of course
Comment 1 Oliver Lehmann 2005-11-01 12:34:27 CET
It looks like, it runs with GNU make, could someone change the Makefile(.in|.am)
so it will continue running with BSD make too which prevents adding extra
dependencies on BSD Systems.
Comment 2 Brian J. Tarricone (not reading bugmail) 2005-11-01 21:25:02 CET
AFAIK, the build system requires GNU make to work properly in some cases.  Benny
could probably give a better answer to this.

Does this dist-hook-local problem disappear when you use gmake?
Comment 3 Oliver Lehmann 2005-11-01 21:54:51 CET
As I said in my own reply - it works with GNU make. This can be fixed (as in
'runs with BSD make as well') by just creating an empty dist-hook-local target:

.PHONY : dist-hook-local
dist-hook-local:

The examples for phony Targets in the GNU make manual are all showing that
.PHONY is used togethger with existing targets. I'm not sure how correct it is
to declare a target as phony w/o defining it. At least BSD make is strict about
that issue and just bails out. I've no idea why automake generates Makefile.in
w/o that target but defining it as a phony one. 
Comment 4 Harold Aling 2007-09-23 18:25:18 CEST
I guess this is fixed in the current version...

Bug #1205

Reported by:
Oliver Lehmann
Reported on: 2005-11-01
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Attachments

Additional information