! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Unintentionally closing window when closing tabs
Status:
RESOLVED: MOVED
Priority:
Very Low
Severity:
enhancement

Comments

Description candyangel 2015-05-20 12:35:25 CEST
Created attachment 6269 
Patch to add 'Preserve Final Tab' option/behaviour

This is a very minor thing but this catches me out a lot when using Thunar, even though I know the behaviour (it also catches me out when using the Leo editor), and I end up closing the Thunar window unintentionally quite often.

Current behaviour is that Thunar will close the window upon closing the last tab, which is the same behaviour as a lot of other file managers (apparently. I only use Thunar, so I don't know personally).

In my opinion, "Close Tab" (Ctrl-W) should only close the tab if there is a tab to be closed (i.e. the tab bar is visible). Otherwise, closing the window is not what the user requested.

However, this would be a significant change in behaviour and would require those that wanted to keep the current behaviour to enable the "Always Show Tabs" (hidden?) option. This would be pretty unreasonable (along with the additional bug reports that Ctrl-W had suddenly "stopped working").

I've attached a proof-of-concept patch which adds a "Preserve Final Tab" preference (in "Behaviour"), which prevents Thunar from closing the last tab. It isn't ideal ("Tabs" frame is actually packed inside the "Middle Click" frame because vbox gets redefined by the "Middle Click" section..) but demonstrates the behaviour I want adding and shows I am willing to/can provide a patch to do so, if it would be acceptable for inclusion.

It may be better to just prompt the user ("Close window? Y/N") if an attempt to close the last tab is made. I'm okay with coding any solution that would be acceptable!

Please note that I don't code in C, nor have I ever used GTK, so the code may be rough and need cleaning up.
Comment 1 Git Bot editbugs 2020-05-26 23:21:37 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/103.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #11921

Reported by:
candyangel
Reported on: 2015-05-20
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

Patch to add 'Preserve Final Tab' option/behaviour (3.33 KB, application/octet-stream)
2015-05-20 12:35 CEST , candyangel
no flags

Additional information