Hi, it seems that xfce4-session ships icons with generic names in system folders, which looks like a bad idea. Those icons are also apparently at the wrong subfolder anyway: /usr/share/icons/hicolor/scalable/apps/system-shutdown.svg /usr/share/icons/hicolor/48x48/apps/system-log-out.png /usr/share/icons/hicolor/48x48/apps/system-reboot.png /usr/share/icons/hicolor/48x48/apps/system-hibernate.png /usr/share/icons/hicolor/48x48/apps/system-shutdown.png /usr/share/icons/hicolor/48x48/apps/system-suspend.png Those apparently belong to actions/ but should they really be shipped in xfce4-session in those global folders?
Yeah, I agree that those are in the wrong folder/s, they should go in hicolor/*/actions/ Using generic icon names on the other hand makes sense, that's the best way to ensure that icon themes will be able to set those icons correctly without having to add DE specific symlinks (like xfsm-shutdown etc). I dunno whether there's another way of ensuring that those icons exist (as a backup if no other icon theme provides them) than installing it in hicolor, so that part - to me - seems okay.
Maybe we can fix this for 4.14 ?
Meanwhile (since 2015 :)) I have read more of the session code and will 1) move the icons to the actions folder and 2) will rename them to xfsm-*, because those are xfce-specific fallback icon names that session uses for the logout dialog.
Simon Steinbeiss referenced this bugreport in commit 3b23006fda8cf9f24878b399e08d0df119daff64 Don't install generic icon names (Bug #11912) https://git.xfce.org/xfce/xfce4-session/commit?id=3b23006fda8cf9f24878b399e08d0df119daff64