! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
verbose logging is always enabled
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Zhihao Yuan 2015-03-13 20:10:41 CET
Check https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198560 for details.

Basically, as documented, the XFSM_VERBOSE environment variable should control whether the verbose logging is on or off, but the end result is, the ability is lost.
Comment 1 Eric Koegel editbugs 2015-03-28 10:36:23 CET
Created attachment 6140 
Make Verbose logging conditonal

Can you verify this patch fixes the issue? Thanks!
Comment 2 Zhihao Yuan 2015-03-28 10:58:23 CET
(In reply to Eric Koegel from comment #1)
> Created attachment 6140 
> Make Verbose logging conditonal
> 
> Can you verify this patch fixes the issue? Thanks!

Yes, but why not just use the old approach, since the "verbose" is
already a global variable exposed by xfsm-global.h?
Comment 3 Zhihao Yuan 2015-03-28 10:58:56 CET
Created attachment 6141 
simple macro-based appraoch
Comment 4 Eric Koegel editbugs 2015-03-28 15:14:59 CET
That works too, pushed to master in:
commit 26f9ae8df629f02af0773df2ed82db6b85c5b556
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Sat Mar 28 16:57:24 2015 +0300

    Make verbose logging conditional (Bug #11698)
    
    Bug report and patch submitted by Zhihao Yuan
http://git.xfce.org/xfce/xfce4-session/commit/?id=26f9ae8df629f02af0773df2ed82db6b85c5b556
Comment 5 MB 2015-06-02 13:09:24 CEST
 (In reply to Eric Koegel from comment #4)
> That works too, pushed to master in:
> commit 26f9ae8df629f02af0773df2ed82db6b85c5b556
> Author: Eric Koegel <eric.koegel@gmail.com>
> Date:   Sat Mar 28 16:57:24 2015 +0300
> 
>     Make verbose logging conditional (Bug #11698)
>     
>     Bug report and patch submitted by Zhihao Yuan
> http://git.xfce.org/xfce/xfce4-session/commit/
> ?id=26f9ae8df629f02af0773df2ed82db6b85c5b556

This bug is still in the version 4.12.1-3
on Debian Sid. The package is created on 2015-05-16.
My System is Debian Sid 32bit with kernel 4.1.0-rc6.
I have it also compile from git too, but the logfiles in my home are created as before.
Can you check it again?
Thanks
Comment 6 Zhihao Yuan 2015-06-02 20:41:04 CEST
(In reply to MB from comment #5)
> 
> This bug is still in the version 4.12.1-3
> on Debian Sid. The package is created on 2015-05-16.

The patched version is not released yet.

> I have it also compile from git too, but the logfiles in my home are created
> as before.
> Can you check it again?

The version compiled from git installs to /usr/local by default, while the deb one installs to /usr, can you double check you have the right binary?  Do you have XFSM_VERBOSE env set?

Anyway, I suggest you to go patch the debian package, and upgrade to it locally, see whether the problem still presents.
Comment 7 MB 2015-06-03 20:00:23 CEST
(In reply to Zhihao Yuan from comment #6)
 
> The version compiled from git installs to /usr/local by default, while the
> deb one installs to /usr, can you double check you have the right binary? 
> Do you have XFSM_VERBOSE env set?


I always compiled with the parameters --prefix=/usr and --disable-debug,
and no, I've not setting the env variable.

So, I've it compiled again from git master, and now is ist ok.
No logs in my home and all is fine.
I don't know, why this not was by the first package from git.

Many thanks for your help.

Bug #11698

Reported by:
Zhihao Yuan
Reported on: 2015-03-13
Last modified on: 2015-06-03

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
4.12.0

Attachments

Make Verbose logging conditonal (1.54 KB, patch)
2015-03-28 10:36 CET , Eric Koegel
no flags
simple macro-based appraoch (468 bytes, patch)
2015-03-28 10:58 CET , Zhihao Yuan
no flags

Additional information